Qt: Add button to main menu's view tab to allow GUI to enter fullscreen.#14566
Qt: Add button to main menu's view tab to allow GUI to enter fullscreen.#14566SDreadnoug2 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
9c354d7 to
325affd
Compare
| } | ||
|
|
||
| void MainWindow::onViewFullscreenGUIActionTriggered(bool checked) { | ||
| Host::SetBaseBoolSettingValue("UI", "MainWindowFullscreen", checked); |
There was a problem hiding this comment.
You can call Host::CommitBaseSettingChanges(); here to save the setting.
Also use git-clang-format (or just regular clang-format if there aren't too many unrelated changes) to format your changes.
|
I'm worried this has the potential to cause confusion. Like if someone tries to enter fullscreen normally, but clicks this option accidentally. Then they'd be left wondering why exiting fullscreen normally doesn't actually exit fullscreen. |
|
Does this really need a menu item? Too many options can cause confusion, UI clutter, and cognitive overload for users. Especially in this case where the two menu items are very similarly named (and "GUI" is just confusing, the game window is also a GUI technically). Moreover, I didn't really see a justification for adding this option.
My suggestion, if you want to expose this setting in the UI, is to change the existing "Start fullscreen" checkbox in Interface settings into a combobox with 4 choices: Never, Game, Main Window, Both (exact wording TBD). Or alternatively add a second checkbox there to fullscreen the main window. Either way, please at least consider hiding this new menu item on macOS. On macOS, every app has a built-in menu item "Enter Full Screen" added by the OS, so this new item is redundant. |
Description of Changes
Fulfills the request for a feature in #14405 which asks to add the option to enter fullscreen from the main menu bar, rather than having to add
MainWindowFullscreen = trueto the PSCX2.ini file.In the view tab of the main menu bar, I've added a Fullscreen(GUI) check box, which on clicking enters fullscreen, and on clicking again exits fullscreen.
Rationale behind Changes
Currently users have to edit their PCSX2.ini file, adding
MainWindowFullscreen = true. Whilst this works, it requires a restart of the program/knowing you're supposed to do that. This simplifies things to a check box.Suggested Testing Steps
Did you use AI to help find, test, or implement this issue or feature?
no