Qt: Add View menu toggle for main window fullscreen#14614
Closed
Cho1409 wants to merge 1 commit into
Closed
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
Looks like this is the same as #14566. That one did forget about the signal blocker though. |
Contributor
Author
|
@chaoticgd Oh you're right, I didn't see that, my bad. Feel free to take his solution btw. |
Member
|
I think we'll go with the first one, seems fair. Looks like the signal blocker isn't strictly required in this case since QAction::triggered only fires on click (although the other checkboxes do use it so I can see why it was added). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a checkable "Fullscreen Main Window" entry to the View menu. Toggling it shows/restores the main window in fullscreen and persists the existing UI/MainWindowFullscreen setting. The menu item is also synchronized with the saved setting on startup.
Rationale behind Changes
The MainWindowFullscreen setting was added in #13249, but until now it could only be enabled by manually editing PCSX2.ini. This exposes it through the GUI so it can be turned on/off without hand-editing the config file. Closes #14405.
Suggested Testing Steps
Did you use AI to help find, test, or implement this issue or feature?
Yes — as an assistant for locating the relevant code, researching how the existing MainWindowFullscreen setting is read/written, and validating the build. I understand and can fully explain the change; the menu action follows the same pattern as the existing View toggles (toolbar/status bar).