You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nit: I think output_json_path and args.output_json from pisa_utils/run.py might confuse people. Maybe call this output_json_file? args.output_json should probably be args.output_json_dir or smth like that #55
Nit: I think output_json_path and args.output_json from pisa_utils/run.py might confuse people. Maybe call this output_json_file? args.output_json should probably be args.output_json_dir or smth like that
Nit: I think
output_json_pathandargs.output_jsonfrompisa_utils/run.pymight confuse people. Maybe call thisoutput_json_file?args.output_jsonshould probably beargs.output_json_diror smth like thatOriginally posted by @mihaitodor in #53 (comment)