Guard os.listdir in PostProcessInterfaceDetailsList.parse() against missing dir and unrelated files#54
Merged
Joseph-Ellaway merged 2 commits intoMay 26, 2026
Conversation
…ror CompileInterfaceSummaryJSON approach Agent-Logs-Url: https://github.com/PDBe-KB/pisa-analysis/sessions/a5c9fa4a-7b33-452b-8efb-694672b776b3 Co-authored-by: Joseph-Ellaway <69363546+Joseph-Ellaway@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Guard May 26, 2026
os.listdir in PostProcessInterfaceDetailsList.parse() against missing dir and unrelated files
a8a3df0
into
PDBE-8507-interface-table-data-only
1 check failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostProcessInterfaceDetailsList.parse()calledos.listdirunconditionally, riskingFileNotFoundErrorwhen no interfaces were generated and inadvertently opening unrelated files in the directory.Changes
os.path.isdirguard beforeos.listdir; logs a warning and returns early if the directory is absentinterface_*.{json,json.gz}(driven byself.compressed) plus anos.path.isfileguard to skip subdirectoriesMirrors the pattern already established in
CompileInterfaceSummaryJSON.parse().