Skip to content

Commit ea3065a

Browse files
committed
replace with actual broadcast
1 parent 342a3a8 commit ea3065a

4 files changed

Lines changed: 1 addition & 11 deletions

File tree

lib/PDL/Graphics/TriD.pm

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -899,7 +899,6 @@ sub PDL::contour3d {
899899
graph_object(PDL::Graphics::TriD::Contours->new(@_));
900900
}
901901

902-
# XXX Should enable different positioning...
903902
*imagrgb3d=*imagrgb3d=\&PDL::imagrgb3d;
904903
sub PDL::imagrgb3d { &checkargs;
905904
require PDL::Graphics::TriD::Image;

lib/PDL/Graphics/TriD/Graph.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ PDL::Graphics::TriD::Graph - PDL 3D graph object with axes
2525
use strict;
2626
use warnings;
2727
use base qw/PDL::Graphics::TriD::Object/;
28-
use PDL::LiteF; # XXX F needed?
28+
use PDL::LiteF;
2929
use PDL::Graphics::TriD::Objects; # axes use Lines etc
3030

3131
use fields qw(Data DataBind UnBound DefaultAxes DefaultAxisName Axis );

lib/PDL/Graphics/TriD/Object.pm

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,7 @@ sub realcoords {
6767
} elsif (@c == 2 and $type eq "LINE") {
6868
@c = (@c[0,1], $c[0]->xvals);
6969
}
70-
# XXX
7170
confess "Must have 3 coordinates if no interpretation (here '$type')" if @c != 3;
72-
# allow a constant (either pdl or not) to be introduced in one dimension
73-
foreach(0..2) {
74-
if (ref($c[$_]) ne "PDL" or $c[$_]->nelem==1) {
75-
$c[$_] = $c[$_]*(PDL->ones($c[($_+1)%3]->dims));
76-
}
77-
}
7871
my $g = PDL::ImageND::combcoords(@c);
7972
$g->dump if $PDL::Graphics::TriD::verbose;
8073
$g;

lib/PDL/Graphics/TriD/Quaternion.pm

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
# Should probably use PDL and C... ?
66
#
77
# Stored as [c,x,y,z].
8-
#
9-
# XXX REMEMBER!!!! First component = cos(angle/2), *NOT* cos(angle)
108

119
package PDL::Graphics::TriD::Quaternion;
1210

0 commit comments

Comments
 (0)