Conversation
|
Great pull request! However, the deployment fails: |
eswenson1
left a comment
There was a problem hiding this comment.
I was able to build and run the docker container successfully. I didn't set up networking, so I don't know whether that works, but I was able to get to DSKDMP and list the files in the "." directory. I was able to start up ITS and see messages from the operator console. So I'm guessing it would work just fine.
larsbrinkhoff
left a comment
There was a problem hiding this comment.
Please look into why deployment fails.
|
I see! I naively used the name of the git repo as name for the Docker repo. My first impulse is to just lowercase said name, but let me take a look at the requirements, just in case there are other limitations (like no hyphens) |
|
Aha. Looks like repos must follow the rule (Taken from these docs) Cool, in that case using the name of the repo in lowercase should work. Let me fix that. |
|
@eswenson1 Great news! Thanks for trying it out :-) |
|
Hmmm. I don't seem to be able to add the new commits to this pull request. Weird, I would have sworn I did something like that in the past. |
|
Done - new pull request: #2365 |
dependencies.shso it works in Ubuntu 24.04KLH10,SIMH,pdp10-ka,pdp10-klandpdp10-ks.lisp.tclbecause half of the time the workflow would fail to build the image forKLH10