fix

Author: ciaranra

crates/pecos-relay-bp/src/lib.rs

@@ -9,7 +9,7 @@
 
 pub mod builder;
 pub mod config;
-pub mod convert;
+pub(crate) mod convert;
 pub mod core_traits;
 pub mod decoder;
 pub mod errors;

python/pecos-rslib/pecos_rslib.pyi

@@ -1541,7 +1541,7 @@ class decoders:
             ...
 
         def gamma0(self, val: float | None) -> decoders.RelayBpBuilder:
-            """Set initial damping factor (default: 0.9, None = disabled)."""
+            """Set initial damping factor (None = disabled)."""
             ...
 
         def pre_iter(self, val: int) -> decoders.RelayBpBuilder:

python/pecos-rslib/src/decoder_bindings.rs

@@ -1615,16 +1615,28 @@ fn parse_stopping_criterion(s: &str) -> PyResult<RustStoppingCriterion> {
 }
 
 /// Convert a dense check matrix from Python lists to an ndarray `Array2`.
-fn dense_check_matrix_to_array2(check_matrix: &[Vec<u8>]) -> Array2<u8> {
+///
+/// # Errors
+///
+/// Returns `PyValueError` if the rows have inconsistent lengths.
+fn dense_check_matrix_to_array2(check_matrix: &[Vec<u8>]) -> PyResult<Array2<u8>> {
     let rows = check_matrix.len();
     let cols = if rows > 0 { check_matrix[0].len() } else { 0 };
+    for (i, row) in check_matrix.iter().enumerate() {
+        if row.len() != cols {
+            return Err(PyErr::new::<pyo3::exceptions::PyValueError, _>(format!(
+                "check_matrix row {i} has length {} but row 0 has length {cols}",
+                row.len()
+            )));
+        }
+    }
     let mut arr = Array2::<u8>::zeros((rows, cols));
     for (i, row) in check_matrix.iter().enumerate() {
         for (j, &val) in row.iter().enumerate() {
             arr[[i, j]] = val;
         }
     }
-    arr
+    Ok(arr)
 }
 
 /// Builder for Relay BP ensemble decoder.
@@ -1676,7 +1688,7 @@ impl PyRelayBpBuilder {
             error_priors,
             max_iter: 200,
             alpha: None,
-            gamma0: Some(0.9),
+            gamma0: None,
             pre_iter: 80,
             num_sets: 300,
             set_max_iter: 60,
@@ -1703,7 +1715,7 @@ impl PyRelayBpBuilder {
         slf
     }
 
-    /// Set initial damping factor (default: 0.9, None = disabled).
+    /// Set initial damping factor (None = disabled).
     ///
     /// Returns:
     ///     Self for method chaining.
@@ -1768,7 +1780,7 @@ impl PyRelayBpBuilder {
     ///     `RuntimeError`: If the configuration is invalid.
     fn build(&self) -> PyResult<PyRelayBpDecoder> {
         let stopping_criterion = parse_stopping_criterion(&self.stopping)?;
-        let arr = dense_check_matrix_to_array2(&self.check_matrix);
+        let arr = dense_check_matrix_to_array2(&self.check_matrix)?;
 
         RustRelayBpBuilder::new(&arr.view())
             .error_priors(&self.error_priors)
@@ -1936,7 +1948,7 @@ impl PyMinSumBpBuilder {
     /// Raises:
     ///     `RuntimeError`: If the configuration is invalid.
     fn build(&self) -> PyResult<PyMinSumBpDecoder> {
-        let arr = dense_check_matrix_to_array2(&self.check_matrix);
+        let arr = dense_check_matrix_to_array2(&self.check_matrix)?;
 
         RustMinSumBpBuilder::new(&arr.view())
             .error_priors(&self.error_priors)

python/quantum-pecos/tests/pecos/decoders/test_decoder_bindings.py

@@ -359,5 +359,141 @@ def test_methods(self) -> None:
         assert result_peel is not None
 
 
+class TestMinSumBpDecoder:
+    """Tests for MinSumBpDecoder via MinSumBpBuilder."""
+
+    def test_create_decoder(self) -> None:
+        """Test construction via builder."""
+        from pecos_rslib.decoders import MinSumBpBuilder
+
+        H = [[1, 1, 0], [0, 1, 1]]
+        decoder = MinSumBpBuilder(H, error_priors=[0.003, 0.003, 0.003]).build()
+
+        assert decoder is not None
+
+    def test_decode_trivial(self) -> None:
+        """Test decoding zero syndrome."""
+        from pecos_rslib.decoders import MinSumBpBuilder
+
+        H = [[1, 1, 0], [0, 1, 1]]
+        decoder = MinSumBpBuilder(H, error_priors=[0.003, 0.003, 0.003]).build()
+
+        result = decoder.decode([0, 0])
+        assert result.converged
+        assert result.decoding == [0, 0, 0]
+
+    def test_decode_single_error(self) -> None:
+        """Test decoding a single-error syndrome."""
+        from pecos_rslib.decoders import MinSumBpBuilder
+
+        H = [[1, 1, 0], [0, 1, 1]]
+        decoder = MinSumBpBuilder(H, error_priors=[0.003, 0.003, 0.003]).build()
+
+        result = decoder.decode([1, 0])
+        assert result.converged
+        assert result.decoding == [1, 0, 0]
+
+    def test_builder_chaining(self) -> None:
+        """Test builder method chaining."""
+        from pecos_rslib.decoders import MinSumBpBuilder
+
+        H = [[1, 1, 0], [0, 1, 1]]
+        decoder = MinSumBpBuilder(H, error_priors=[0.003, 0.003, 0.003]).max_iter(100).alpha(0.8).gamma0(0.5).build()
+
+        result = decoder.decode([0, 0])
+        assert result.converged
+
+    def test_properties(self) -> None:
+        """Test check_count and bit_count properties."""
+        from pecos_rslib.decoders import MinSumBpBuilder
+
+        H = [[1, 1, 0, 0], [0, 1, 1, 0], [0, 0, 1, 1]]
+        decoder = MinSumBpBuilder(H, error_priors=[0.01, 0.01, 0.01, 0.01]).build()
+
+        assert decoder.check_count == 3
+        assert decoder.bit_count == 4
+
+
+class TestRelayBpDecoder:
+    """Tests for RelayBpDecoder via RelayBpBuilder."""
+
+    def test_create_decoder(self) -> None:
+        """Test construction via builder."""
+        from pecos_rslib.decoders import RelayBpBuilder
+
+        H = [[1, 1, 0], [0, 1, 1]]
+        decoder = RelayBpBuilder(H, error_priors=[0.003, 0.003, 0.003]).build()
+
+        assert decoder is not None
+
+    def test_decode_trivial(self) -> None:
+        """Test decoding zero syndrome."""
+        from pecos_rslib.decoders import RelayBpBuilder
+
+        H = [[1, 1, 0], [0, 1, 1]]
+        decoder = RelayBpBuilder(H, error_priors=[0.003, 0.003, 0.003]).seed(42).build()
+
+        result = decoder.decode([0, 0])
+        assert result.converged
+        assert result.decoding == [0, 0, 0]
+
+    def test_decode_single_error(self) -> None:
+        """Test decoding a single-error syndrome."""
+        from pecos_rslib.decoders import RelayBpBuilder
+
+        H = [[1, 1, 0], [0, 1, 1]]
+        decoder = RelayBpBuilder(H, error_priors=[0.003, 0.003, 0.003]).seed(42).build()
+
+        result = decoder.decode([1, 0])
+        assert result.converged
+        assert result.decoding == [1, 0, 0]
+
+    def test_builder_chaining(self) -> None:
+        """Test builder method chaining with relay-specific options."""
+        from pecos_rslib.decoders import RelayBpBuilder
+
+        H = [[1, 1, 0], [0, 1, 1]]
+        decoder = (
+            RelayBpBuilder(H, error_priors=[0.003, 0.003, 0.003])
+            .max_iter(100)
+            .gamma0(0.9)
+            .pre_iter(40)
+            .num_sets(20)
+            .set_max_iter(30)
+            .seed(42)
+            .stopping("n_conv_1")
+            .build()
+        )
+
+        result = decoder.decode([0, 0])
+        assert result.converged
+
+    def test_properties(self) -> None:
+        """Test check_count and bit_count properties."""
+        from pecos_rslib.decoders import RelayBpBuilder
+
+        H = [[1, 1, 0, 0], [0, 1, 1, 0], [0, 0, 1, 1]]
+        decoder = RelayBpBuilder(H, error_priors=[0.01, 0.01, 0.01, 0.01]).build()
+
+        assert decoder.check_count == 3
+        assert decoder.bit_count == 4
+
+    def test_seed_reproducibility(self) -> None:
+        """Test that same seed gives same results."""
+        from pecos_rslib.decoders import RelayBpBuilder
+
+        H = [[1, 1, 0], [0, 1, 1]]
+        priors = [0.003, 0.003, 0.003]
+
+        d1 = RelayBpBuilder(H, error_priors=priors).seed(123).build()
+        d2 = RelayBpBuilder(H, error_priors=priors).seed(123).build()
+
+        r1 = d1.decode([1, 0])
+        r2 = d2.decode([1, 0])
+
+        assert r1.decoding == r2.decoding
+        assert r1.converged == r2.converged
+
+
 if __name__ == "__main__":
     pytest.main([__file__, "-v"])