Making sure conditional error modeling works (#154)

* Making sure conditional error modeling works

Author: ciaranra

crates/pecos-cli/tests/simple_determinism_test.rs

@@ -254,7 +254,7 @@ fn test_noise_impact_on_determinism() -> Result<(), Box<dyn std::error::Error>>
 ///
 /// NOTE: Currently skipped as worker count determinism is an open issue in PECOS
 #[test]
-#[ignore]
+#[ignore = "worker count determinism is an open issue in PECOS"]
 fn test_worker_count_consistency() -> Result<(), Box<dyn std::error::Error>> {
     let manifest_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
     let phir_path = manifest_dir.join("../../examples/phir/simple_test.json");

python/quantum-pecos/src/pecos/engines/hybrid_engine_old.py

@@ -158,7 +158,7 @@ def run(
                 error_circuits = error_gen.generate_tick_errors(
                     tick_circuit,
                     time,
-                    # output,
+                    output,
                     **params,
                 )
                 errors = error_circuits.get(time, {})

python/quantum-pecos/src/pecos/error_models/fake_error_model.py

@@ -60,6 +60,7 @@ def generate_tick_errors(
         self,
         _tick_circuit: QuantumCircuit,
         _time: int | tuple[int, ...],
+        _output: dict,
         **_params: GateParams,
     ) -> ErrorCircuits:
         """Generate tick errors that ignores parameters and returns pre-configured error circuits."""

python/tests/pecos/integration/test_hybrid_engine_old_error_model.py

@@ -0,0 +1,26 @@
+"""Integration tests for hybrid engine with old error model."""
+
+from pecos import HybridEngine, QuantumCircuit
+from pecos.error_models.error_depolar import DepolarizingErrorModel
+from pecos.simulators import SparseSim
+
+
+def test_simple_conditional() -> None:
+    """Verify simulation and noise modeling works with conditional operations."""
+    qc = QuantumCircuit(cvar_spec={"m": 1, "a": 1}, num_qubits=1)
+    qc.append("X", {0}, cond={"a": "a", "op": "==", "b": 0})
+    qc.append("measure Z", {0}, var_output={0: ("m", 0)})
+
+    eng = HybridEngine()
+    state = SparseSim(1)
+    err = DepolarizingErrorModel()
+
+    error_params = {
+        "p1": 0.01,
+        "p2": 0.01,
+        "p_init": 0.01,
+        "p_meas": 0.01,
+        "p2_mem": 0.01,
+    }
+
+    eng.run(state, qc, error_gen=err, shot_id=0, error_params=error_params)