make the llvm feature not default for Rust

Author: ciaranra

.github/workflows/rust-test.yml

@@ -74,7 +74,7 @@ jobs:
         run: rustup component add clippy
 
       - name: Run clippy
-        run: cargo clippy --workspace --all-targets -- -D warnings
+        run: cargo clippy --workspace --all-targets --features llvm -- -D warnings
 
   rust-lint-no-llvm:
     runs-on: ubuntu-latest
@@ -245,11 +245,11 @@ jobs:
 
           echo "RUSTFLAGS: $RUSTFLAGS"
 
-          cargo test --no-run
+          cargo test --no-run --features llvm
 
       - name: Compile tests (Linux/Windows)
         if: matrix.os != 'macos-latest'
-        run: cargo test --no-run
+        run: cargo test --no-run --features llvm
 
       - name: Run tests (macOS)
         if: matrix.os == 'macos-latest'
@@ -264,7 +264,7 @@ jobs:
           unset PKG_CONFIG_PATH
           export LIBRARY_PATH=/usr/lib
 
-          cargo test --workspace
+          cargo test --workspace --features llvm
 
       - name: Run tests (Linux)
         if: matrix.os == 'ubuntu-latest'
@@ -274,13 +274,13 @@ jobs:
         if: matrix.os == 'windows-latest'
         run: |
           # Run all non-doctest tests
-          cargo test --workspace --exclude pecos-rslib --lib --bins --tests --examples
+          cargo test --workspace --features llvm --exclude pecos-rslib --lib --bins --tests --examples
 
           # For Windows, we need to run doctests for the pecos crate specially
           # to ensure they run from the crate directory
           cd crates/pecos
-          cargo test --doc
+          cargo test --doc --features llvm
           cd ../..
 
           # Run doctests for other crates normally
-          cargo test --workspace --exclude pecos-rslib --exclude pecos --doc
+          cargo test --workspace --features llvm --exclude pecos-rslib --exclude pecos --doc

Makefile

@@ -238,11 +238,13 @@ lint-fix:  ## Fix all auto-fixable linting issues (Rust, Python, Julia)
 
 .PHONY: rstest
 rstest:  ## Run Rust tests
-	@$(ADD_LLVM_TO_PATH) cargo test --workspace --release
+	@$(ADD_LLVM_TO_PATH) cargo test --workspace --release --exclude pecos-quest --exclude pecos-decoders --features llvm
+	@$(ADD_LLVM_TO_PATH) cargo test -p pecos-quest --release
+	@$(ADD_LLVM_TO_PATH) cargo test -p pecos-decoders --release --all-features
 
 .PHONY: rstest-all
 rstest-all:  ## Run Rust tests with all features except GPU
-	@$(ADD_LLVM_TO_PATH) cargo test --workspace --exclude pecos-quest --exclude pecos-decoders
+	@$(ADD_LLVM_TO_PATH) cargo test --workspace --exclude pecos-quest --exclude pecos-decoders --features llvm
 	@$(ADD_LLVM_TO_PATH) cargo test -p pecos-quest
 	@$(ADD_LLVM_TO_PATH) cargo test -p pecos-decoders --all-features
 

crates/pecos-cli/Cargo.toml

@@ -23,7 +23,7 @@ env_logger.workspace = true
 log.workspace = true
 
 [features]
-default = ["qasm", "llvm", "phir", "selene"]
+default = ["qasm", "phir", "selene"]
 qasm = ["pecos/qasm"]
 llvm = ["pecos/llvm"]
 phir = ["pecos/phir"]

crates/pecos-hugr-qis/Cargo.toml

@@ -27,7 +27,7 @@ tket.workspace = true
 tket-qsystem.workspace = true
 
 [features]
-default = ["llvm"]
+default = []
 llvm = ["tket-qsystem/llvm"]
 
 [lints]

crates/pecos-qis-core/Cargo.toml

@@ -30,7 +30,7 @@ features = ["llvm14-0"]
 optional = true
 
 [features]
-default = ["llvm"]
+default = []
 llvm = ["dep:inkwell"]
 
 [build-dependencies]

crates/pecos/Cargo.toml

@@ -38,7 +38,7 @@ pecos-quest = { workspace = true, optional = true }
 pecos-qulacs = { workspace = true, optional = true }
 
 [features]
-default = ["selene", "llvm", "qasm", "phir", "all-simulators"]
+default = ["selene", "qasm", "phir", "all-simulators"]
 qasm = []
 llvm = ["pecos-qis-core/llvm", "pecos-hugr-qis", "pecos-hugr-qis?/llvm"]
 phir = []

julia/pecos-julia-ffi/Cargo.toml

@@ -17,7 +17,8 @@ crate-type = ["cdylib"]
 
 [dependencies]
 # PECOS - the meta crate that includes everything via its prelude
-pecos = { workspace = true }
+# Enable llvm feature explicitly for full Julia functionality
+pecos = { workspace = true, features = ["llvm"] }
 
 [lints]
 workspace = true

python/pecos-rslib/rust/Cargo.toml

@@ -21,7 +21,8 @@ test = false
 
 [dependencies]
 # Use the pecos metacrate which includes all simulators and runtimes by default
-pecos = { workspace = true }
+# Enable llvm feature explicitly for full Python functionality
+pecos = { workspace = true, features = ["llvm"] }
 
 pyo3 = { workspace=true, features = ["extension-module", "abi3-py310", "generate-import-lib"] }
 parking_lot.workspace = true

python/quantum-pecos/tests/guppy/test_hugr_compilation.py

@@ -39,7 +39,7 @@ def test_rust_hugr_crate_compilation(self) -> None:
 
         # Test compilation of pecos-hugr-qis crate
         result = subprocess.run(
-            [cargo_path, "check", "-p", "pecos-hugr-qis"],
+            [cargo_path, "check", "-p", "pecos-hugr-qis", "--features", "llvm"],
             capture_output=True,
             text=True,
             cwd=project_root,
@@ -75,7 +75,16 @@ def test_rust_hugr_unit_tests(self) -> None:
 
         # Run HUGR-specific unit tests
         result = subprocess.run(
-            [cargo_path, "test", "-p", "pecos-hugr-qis", "--", "--nocapture"],
+            [
+                cargo_path,
+                "test",
+                "-p",
+                "pecos-hugr-qis",
+                "--features",
+                "llvm",
+                "--",
+                "--nocapture",
+            ],
             capture_output=True,
             text=True,
             cwd=project_root,