Add confirmation prompt to pecos upgrade

Author: ciaranra

crates/pecos/src/bin/cli.rs

@@ -626,8 +626,13 @@ pub fn run_uninstall(targets: &[String], all: bool, yes: bool) -> pecos_build::R
 /// # Errors
 ///
 /// Returns an error if any target fails to upgrade.
-pub fn run_upgrade(targets: &[String], all: bool, no_configure: bool) -> pecos_build::Result<()> {
-    upgrade_cmd::run(targets, all, no_configure)
+pub fn run_upgrade(
+    targets: &[String],
+    all: bool,
+    no_configure: bool,
+    yes: bool,
+) -> pecos_build::Result<()> {
+    upgrade_cmd::run(targets, all, no_configure, yes)
 }
 
 /// Run the sys-info command

crates/pecos/src/bin/cli/upgrade_cmd.rs

@@ -4,12 +4,13 @@
 
 use pecos_build::Result;
 use pecos_build::errors::Error;
+use pecos_build::prompt::{PromptMode, confirm};
 
 /// Known upgradeable targets
 const KNOWN_TARGETS: &[&str] = &["cuda", "llvm", "cuquantum"];
 
 /// Run the upgrade command
-pub fn run(targets: &[String], all: bool, no_configure: bool) -> Result<()> {
+pub fn run(targets: &[String], all: bool, no_configure: bool, yes: bool) -> Result<()> {
     let targets: Vec<&str> = if all {
         KNOWN_TARGETS.to_vec()
     } else {
@@ -34,6 +35,23 @@ pub fn run(targets: &[String], all: bool, no_configure: bool) -> Result<()> {
         ordered
     };
 
+    println!("This will force-reinstall:");
+    for target in &targets {
+        println!("  {target}");
+    }
+    println!();
+
+    let mode = if yes {
+        PromptMode::AcceptAll
+    } else {
+        PromptMode::Interactive
+    };
+
+    if !confirm("Continue?", false, mode) {
+        println!("Cancelled.");
+        return Ok(());
+    }
+
     let total = targets.len();
     for (i, target) in targets.iter().enumerate() {
         println!("[{}/{}] Upgrading {target}...", i + 1, total);
@@ -42,7 +60,7 @@ pub fn run(targets: &[String], all: bool, no_configure: bool) -> Result<()> {
         println!();
     }
 
-    println!("All done.");
+    println!("All done. Run `just build` to rebuild PECOS.");
     Ok(())
 }
 

crates/pecos/src/bin/pecos.rs

@@ -235,6 +235,10 @@ enum Commands {
         /// Skip automatic configuration after installation (applies to llvm)
         #[arg(long)]
         no_configure: bool,
+
+        /// Skip confirmation prompt
+        #[arg(long, short)]
+        yes: bool,
     },
     /// Show system tools and project info
     #[command(name = "sys-info")]
@@ -764,7 +768,8 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
             targets,
             all,
             no_configure,
-        } => cli::run_upgrade(targets, *all, *no_configure)?,
+            yes,
+        } => cli::run_upgrade(targets, *all, *no_configure, *yes)?,
         Commands::SysInfo => cli::run_sys_info()?,
         Commands::List { verbose } => cli::run_list(*verbose)?,
         Commands::Self_ { command } => cli::run_self(command.clone())?,