Skip to content

Commit 6cb3f55

Browse files
committed
Fix false positives when validating parameter table
For single-row validation, don't pass any other dataframes/models to `petab.check_parameter_df` to avoid false positives due to the incomplete parameter table. Closes #126.
1 parent d484231 commit 6cb3f55

1 file changed

Lines changed: 19 additions & 11 deletions

File tree

src/petab_gui/controllers/table_controllers.py

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1278,19 +1278,27 @@ def check_petab_lint(
12781278
col_name: str = None,
12791279
):
12801280
"""Check a number of rows of the model with petablint."""
1281+
# Validate full parameter table
12811282
if row_data is None:
12821283
row_data = self.model.get_df()
1283-
observable_df = self.mother_controller.model.observable.get_df()
1284-
measurement_df = self.mother_controller.model.measurement.get_df()
1285-
condition_df = self.mother_controller.model.condition.get_df()
1286-
sbml_model = self.mother_controller.model.sbml.get_current_sbml_model()
1287-
return petab.check_parameter_df(
1288-
row_data,
1289-
observable_df=observable_df,
1290-
measurement_df=measurement_df,
1291-
condition_df=condition_df,
1292-
model=sbml_model,
1293-
)
1284+
observable_df = self.mother_controller.model.observable.get_df()
1285+
measurement_df = self.mother_controller.model.measurement.get_df()
1286+
condition_df = self.mother_controller.model.condition.get_df()
1287+
sbml_model = (
1288+
self.mother_controller.model.sbml.get_current_sbml_model()
1289+
)
1290+
return petab.check_parameter_df(
1291+
row_data,
1292+
observable_df=observable_df,
1293+
measurement_df=measurement_df,
1294+
condition_df=condition_df,
1295+
model=sbml_model,
1296+
)
1297+
1298+
# Validate a single parameter row
1299+
# In this case, we don't pass any other dataframes/models to avoid
1300+
# false positives due to the incomplete parameter table.
1301+
return petab.check_parameter_df(row_data)
12941302

12951303

12961304
class VisualizationController(TableController):

0 commit comments

Comments
 (0)