PEP8 standard RET504 (#249)

Author: PaulJonasJost

pyproject.toml

@@ -90,7 +90,6 @@ lint.ignore = [
     # FIXME: those are ignored for now, should be fixed eventually
     "E501",  # Ignore line too long
     "ERA001", # Found commented-out code
-    "RET504",  # Unnecessary assignment before `return`
     "T201",  # `print` found"
     "SIM105",  # Use `contextlib.suppress`
     "S110",  # `try`-`except`-`pass` detected, consider logging the exception

src/petab_gui/models/pandas_table_model.py

@@ -245,8 +245,7 @@ def headerData(self, section, orientation, role=Qt.DisplayRole):
                     section - self.column_offset
                 ]
             if role == Qt.ToolTipRole:
-                tooltip_header = header_tip(self.table_type, col_label)
-                return tooltip_header
+                return header_tip(self.table_type, col_label)
             if role == Qt.WhatsThisRole:
                 return column_whats_this(self.table_type, col_label)
             return col_label

src/petab_gui/models/sbml_model.py

@@ -69,5 +69,4 @@ def _get_model_id(self):
         """Extract the model ID from the SBML text."""
         document = libsbml.readSBMLFromString(self.sbml_text)
         model = document.getModel()
-        model_id = model.getIdAttribute() or "New_File"
-        return model_id
+        return model.getIdAttribute() or "New_File"