..

Author: dweindl

petab/v2/core.py

@@ -861,9 +861,10 @@ class Parameter(BaseModel):
     prior_distribution: PriorDistribution | None = Field(
         alias=C.PRIOR_DISTRIBUTION, default=None
     )
-
-    # TODO priors
-    #  pydantic vs. petab.v1.priors.Prior
+    #: Prior distribution parameters.
+    prior_parameters: list[float] = Field(
+        alias=C.PRIOR_PARAMETERS, default_factory=list
+    )
 
     #: :meta private:
     model_config = ConfigDict(
@@ -882,13 +883,22 @@ def _validate_id(cls, v):
             raise ValueError(f"Invalid ID: {v}")
         return v
 
+    @field_validator("prior_parameters", mode="before")
+    @classmethod
+    def _validate_prior_parameters(cls, v):
+        if isinstance(v, str):
+            v = v.split(C.PARAMETER_SEPARATOR)
+        elif not isinstance(v, Sequence):
+            v = [v]
+
+        return [float(x) for x in v]
+
     @field_validator("estimate", mode="before")
     @classmethod
     def _validate_estimate_before(cls, v):
         if isinstance(v, bool):
             return v
 
-        # TODO: clarify whether extra whitespace is allowed
         if isinstance(v, str):
             v = v.strip().lower()
             if v == "true":
@@ -932,8 +942,6 @@ def _validate(self) -> Self:
         ):
             raise ValueError("Lower bound must be less than upper bound.")
 
-        # TODO parameterScale?
-
         # TODO priorType, priorParameters
 
         return self

petab/v2/problem.py

@@ -976,7 +976,9 @@ def add_parameter(
         if prior_dist is not None:
             record[PRIOR_DISTRIBUTION] = prior_dist
         if prior_pars is not None:
-            if not isinstance(prior_pars, str):
+            if isinstance(prior_pars, Sequence) and not isinstance(
+                prior_pars, str
+            ):
                 prior_pars = PARAMETER_SEPARATOR.join(map(str, prior_pars))
             record[PRIOR_PARAMETERS] = prior_pars
         record.update(kwargs)
@@ -1117,6 +1119,7 @@ def model_dump(self, **kwargs) -> dict[str, Any]:
                          'lb': 0.0,
                          'nominal_value': None,
                          'prior_distribution': None,
+                         'prior_parameters': [],
                          'ub': 1.0}]}
         """
         res = {