Skip to content

Updates to sciml model test cases for PEtav v2#30

Merged
sebapersson merged 1 commit intomainfrom
bes/petabv2_fixes
Mar 25, 2026
Merged

Updates to sciml model test cases for PEtav v2#30
sebapersson merged 1 commit intomainfrom
bes/petabv2_fixes

Conversation

@BSnelling
Copy link
Copy Markdown
Collaborator

Comment thread src/petab/yaml.jl
:neural_nets => Dict(),
:array_files => String[]
:array_files => String[],
:version => "0.1.0",
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the petab_sciml format specification have a version yet?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, 0.1.0 will be the first version, but lets wait with that feature until we actually release 0.1

@BSnelling BSnelling requested a review from sebapersson March 12, 2026 10:03
@sebapersson
Copy link
Copy Markdown
Collaborator

Thanks a lot for spotting this! I will check nothing broke with PEtab.jl, then I will merge!

Copy link
Copy Markdown
Collaborator

@sebapersson sebapersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected in PEtab.jl, so I will merge.

Thanks again!

@sebapersson sebapersson merged commit 44da088 into main Mar 25, 2026
1 check passed
@sebapersson sebapersson deleted the bes/petabv2_fixes branch March 25, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants