[Cpp API Compatibility] Align tests with PyTorch 2.13.0#76
Open
youge325 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s CI and compatibility tests to match PyTorch (LibTorch) 2.13.0, including removing test cases for APIs that are no longer public in that version.
Changes:
- Bumped the Linux CPU workflow job to download and use LibTorch 2.13.0 (CPU).
- Updated the (still disabled) Linux CUDA workflow job to target Paddle nightly cu126 and LibTorch 2.13.0+cu126.
- Removed compatibility tests for
TensorBase::has_namesandTensor::rename, aligning with their removal from PyTorch 2.13.0’s public API surface.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/ATen/ops/MiscTensorTest.cpp | Removes the Tensor::rename test case that is no longer applicable for PyTorch 2.13.0. |
| test/ATen/core/TensorAccessorTest.cpp | Removes the has_names test case that targets a no-longer-public API. |
| .github/workflows/compile-test.yml | Updates LibTorch download URLs to 2.13.0 (CPU) and adjusts the disabled CUDA job to cu126 + LibTorch 2.13.0+cu126. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if: ${{ false }}.TensorBase::has_namesandTensor::rename, which are no longer public APIs in PyTorch 2.13.0.Dependency URLs
https://download.pytorch.org/libtorch/cpu/libtorch-shared-with-deps-2.13.0%2Bcpu.ziphttps://download.pytorch.org/libtorch/cu126/libtorch-shared-with-deps-2.13.0%2Bcu126.zipBoth archives were checked successfully over HTTP. The CUDA job remains disabled until a CUDA 12.6-capable runner is available.
Companion Paddle PR