Don't bother sending remove packet

Author: calcastor

platform/platform-modern/src/main/java/dev/pgm/community/platform/modern/ModernPlayerUtils.java

@@ -20,7 +20,6 @@
 import java.util.List;
 import java.util.Map;
 import java.util.UUID;
-import net.minecraft.network.protocol.game.ClientboundPlayerInfoRemovePacket;
 import net.minecraft.network.protocol.game.ClientboundPlayerInfoUpdatePacket;
 import net.minecraft.network.protocol.game.ClientboundSetPlayerTeamPacket;
 import net.minecraft.server.level.ServerPlayer;
@@ -144,19 +143,18 @@ public void refreshPlayer(@Nullable PacketEvent event, Player player, Player vie
       realProfile.properties().get("textures").forEach(p -> builder.put("textures", p));
     }
 
-    viewerNms.connection.send(new ClientboundPlayerInfoRemovePacket(List.of(player.getUniqueId())));
     nmsPlayer.gameProfile =
         new GameProfile(realProfile.id(), playerName, new PropertyMap(builder.build()));
     viewerNms.connection.send(
         ClientboundPlayerInfoUpdatePacket.createPlayerInitializing(List.of(nmsPlayer), viewerNms));
     nmsPlayer.gameProfile = realProfile;
 
     Scoreboard scoreboard = nmsPlayer.getBukkitEntity().getScoreboard().getHandle();
-    PlayerTeam nmsTeam = scoreboard.getPlayersTeam(player.getName());
+    PlayerTeam team = scoreboard.getPlayersTeam(player.getName());
 
-    if (nmsTeam != null) {
-      ClientboundSetPlayerTeamPacket teamPacket = ClientboundSetPlayerTeamPacket.createPlayerPacket(
-          nmsTeam, playerName, ClientboundSetPlayerTeamPacket.Action.ADD);
+    if (team != null) {
+      var teamPacket = ClientboundSetPlayerTeamPacket.createPlayerPacket(
+          team, playerName, ClientboundSetPlayerTeamPacket.Action.ADD);
 
       viewerNms.connection.send(teamPacket);
     }