New Universal.Enums.EnumProtectedMember sniff#454
Open
rodrigoprimo wants to merge 1 commit into
Open
Conversation
…ected enum members Add the `Universal.Enums.EnumProtectedMember` sniff which requires non-public enum members (methods and constants) to be declared `private` instead of `protected`. As enums cannot be extended, `protected` is functionally equivalent to `private` for an enum member. This complies with PER Coding Style 2.0 (section 9). Fixes 442. Ref: https://github.com/php-fig/per-coding-style/blob/2.0.0/spec.md#9-enumerations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sniff requires non-public enum members (methods and constants) to be declared
privateinstead ofprotected. As enums cannot be extended,protectedvisibility is functionally equivalent toprivatefor an enum member.This follows PER Coding Style 2.0 (section 9):
Separate error codes (
MethodFoundandConstantFound) are used, so either case can be excluded independently if desired. PER-CS 2.0 enforces this rule on methods only. The upcoming PER-CS 3.1 is expected to enforce it on classs constants as well (see php-fig/per-coding-style#151).Fixes #442.
Suggested changelog entry
Universal.Enums.EnumProtectedMembersniff to require non-public enum members (methods and constants) to be declaredprivateinstead ofprotected.