Requirements: document iconv as a recommended PHP extension#91
Conversation
|
=== This is an auto-generated comment === Thank you for your PR. Please review the resulting final markdown files via the created artifact. N.B.: the above link will automatically be updated when this PR is updated. |
jrfnl
left a comment
There was a problem hiding this comment.
Thanks @rodrigoprimo !
Potential follow-up:
Would it be an idea to add a suggest section to the composer.json file of the PHPCS package with this recommendation too ?
https://getcomposer.org/doc/04-schema.md#suggest
|
Oh, just thinking as another potential follow-up: may be the |
|
Oh and another one as potential follow up related to: PHPCSStandards/PHP_CodeSniffer#294 - have a |
Description
As suggested in squizlabs/PHP_CodeSniffer#3923 (comment), this PR adds iconv to the Requirements wiki page as a strongly recommended PHP extension. Without it, PHP_CodeSniffer falls back to byte-based length calculations, which can cause sniffs like
Generic.Files.LineLengthto report incorrect results for files containing multibyte characters.Related issues/external references
Discussed in squizlabs/PHP_CodeSniffer#3923
PR checklist
_Sidebar.mdfile.