-
-
Notifications
You must be signed in to change notification settings - Fork 107
Expand file tree
/
Copy pathValidDefaultValueSniff.php
More file actions
81 lines (66 loc) · 2.44 KB
/
ValidDefaultValueSniff.php
File metadata and controls
81 lines (66 loc) · 2.44 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
<?php
/**
* Ensures function params with default values are at the end of the declaration.
*
* @author Greg Sherwood <gsherwood@squiz.net>
* @copyright 2006-2015 Squiz Pty Ltd (ABN 77 084 670 600)
* @license https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
*/
namespace PHP_CodeSniffer\Standards\PEAR\Sniffs\Functions;
use PHP_CodeSniffer\Files\File;
use PHP_CodeSniffer\Sniffs\Sniff;
class ValidDefaultValueSniff implements Sniff
{
/**
* Returns an array of tokens this test wants to listen for.
*
* @return array<int|string>
*/
public function register()
{
return [
T_FUNCTION,
T_CLOSURE,
T_FN,
];
}//end register()
/**
* Processes this test, when one of its tokens is encountered.
*
* @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
* @param int $stackPtr The position of the current token in the
* stack passed in $tokens.
*
* @return void
*/
public function process(File $phpcsFile, $stackPtr)
{
// Flag for when we have found a default in our arg list.
// If there is a value without a default after this, it is an error.
$defaultFound = false;
$params = $phpcsFile->getMethodParameters($stackPtr);
foreach ($params as $param) {
if ($param['variable_length'] === true) {
continue;
}
if (array_key_exists('default', $param) === true) {
$defaultFound = true;
$defaultValueLc = strtolower($param['default']);
// Check if the arg is type hinted and using NULL for the default.
// This does not make the argument optional - it just allows NULL
// to be passed in.
if ($param['type_hint'] !== ''
&& ($defaultValueLc === 'null' || $defaultValueLc === '\null')
) {
$defaultFound = false;
}
continue;
}
if ($defaultFound === true) {
$error = 'Arguments with default values must be at the end of the argument list';
$phpcsFile->addError($error, $param['token'], 'NotAtEnd');
return;
}
}//end foreach
}//end process()
}//end class