-
-
Notifications
You must be signed in to change notification settings - Fork 108
Expand file tree
/
Copy pathNonExecutableCodeUnitTest.1.inc
More file actions
434 lines (360 loc) · 8.25 KB
/
Copy pathNonExecutableCodeUnitTest.1.inc
File metadata and controls
434 lines (360 loc) · 8.25 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
<?php
switch ($var) {
case '1':
return;
echo 'hi';
case '2':
case '3':
if ($something === true) {
break;
echo 'hi';
}
break;
default:
return;
if ($something === true) {
break;
echo 'hi';
}
}
function myFunction($var)
{
if ($something === TRUE) {
return;
echo 'hi';
}
return;
return FALSE;
if ($something === TRUE) {
return TRUE;
}
}//end myFunction()
foreach ($vars as $var) {
if ($something === TRUE) {
continue;
break;
} else {
continue;
echo 'hi';
}
echo $var."\n";
}
switch ($lowerVarType) {
case 'bool':
return 'boolean';
echo 'hi';
case 'double':
case 'real':
return 'float';
echo 'hi';
}
while ($line=fgets($fp,2*1024*1024))
{
if (!preg_match("/^<([a-z0-9_]+)/",$line,$matches))
continue;
print $line;
}
switch ($var) {
case 1:
echo '1';
break;
echo 'non-executable';
default:
echo '2';
break;
}
switch (0) {
case 1:
return '1';
echo 'non-executable';
default:
break;
}
function myFunction()
{
if ($something === TRUE) {
return;
}
echo 'foo';
return;
}//end myFunction()
function myFunction()
{
return uksort(
$array,
function() {
return mt_rand(-1, 1);
echo 'done';
}
);
}//end myFunction()
public static function thisCausesAnError() {
return new foo(function() {return $foo;}
);
}
function myFunction()
{
if ($something === TRUE) {
throw new Exception('exception');
}
throw new Exception('exception');
echo 'non-executable';
}//end myFunction()
switch ($var) {
case 1: {
return '1';
}
case 2: {
return '2';
}
}
defined('FOO') or die('error');
defined('FOO') || die('error');
interface myInterface {
function myFunc();
}
echo 'hello';
function foo($color) {
switch ($color) {
case 'red':
return 'yuck';
break;
case 'blue':
return 'yuck';
break;
case 'orange':
return 'yay';
break;
default:
return 'boring';
}
}
function returnOverMultipleLines($color) {
switch ($color) {
case 'red':
return someFunction(
'multiple',
'arguments'
);
echo $foo;
default:
return array(
'multiline',
'array'
);
}
}
function test() {
return array(
'multiline',
'array'
);
echo $foo;
}
function test(){
switch($a) {
case 1:
if (empty($b))
return 0;
break;
default:
return 2;
}
if (empty($a))
echo '1';
elseif ($empty($b))
return 0;
else
return 1;
echo "oi";
return 1;
}
switch ($foo) {
case 'foo':
if ($foo)
return $foo;
return $bar;
default:
return $bar;
}
function foo()
{
return $bar->{$action . 'JsonAction'}();
}
switch (true) {
case 1:
return foo(
function () {
$foo = $bar; // when this is removed it works ok
return false; // from here on it reports unreachable
}
);
}
for($i=0,$j=50; $i<100; $i++) {
while($j--) {
if($j==17) {
goto end;
echo 'unreachable';
}
}
}
switch ($var) {
case '1':
goto end;
echo 'hi';
case '2':
case '3':
if ($something === true) {
goto end;
echo 'hi';
}
break;
default:
goto end;
if ($something === true) {
goto end;
echo 'hi';
}
}
end:
echo 'j hit 17';
// Issue 2512.
class TestAlternativeControlStructures {
public function alternative_switch_in_function( $var ) {
switch ( $var ) :
case 'value1':
do_something();
break;
default:
case 'value2':
do_something_else();
break;
endswitch;
}
public function various_alternative_control_structures() {
$_while = 1;
for ( $a = 0; $a++ < 1; ) :
foreach ( [ 1 ] as $b ) :
while ( $_while-- ) :
if ( 1 ) :
switch ( 1 ) :
default:
echo 'yay, we made it!';
break;
endswitch;
endif;
endwhile;
endforeach;
endfor;
}
}
$var_after_class_in_global_space = 1;
do_something_else();
// These are parse errors, but that's not the concern of the sniff.
function parseError1() {
defined('FOO') or return 'foo';
echo 'unreachable';
}
function parseError2() {
defined('FOO') || continue;
echo 'unreachable';
}
// All logical operators are allowed with inline expressions (but this was not correctly handled by the sniff).
function exitExpressionsWithLogicalOperators() {
$condition = false;
$condition || \exit();
$condition or die();
$condition = true;
$condition && die();
$condition and exit;
$condition xor die();
echo 'still executable as exit, in all of the above cases, is used as part of an expression';
}
// Inline expressions are allowed in ternaries.
function exitExpressionsInTernary() {
$value = $myValue ? $myValue : exit();
$value = $myValue ?: exit();
$value = $var == 'foo' ? 'bar' : \die( 'world' );
$value = (!$myValue ) ? exit() : $myValue;
$value = $var != 'foo' ? die( 'world' ) : 'bar';
echo 'still executable';
}
// Inline expressions are allowed with null coalesce and null coalesce equals.
function exitExpressionsWithNullCoalesce() {
$value = $nullableValue ?? exit();
$value ??= die();
echo 'still executable';
}
// Inline expressions are allowed in arrow functions.
function exitExpressionsInArrowFunction() {
$callable = fn() => die();
echo 'still executable';
}
// PHP 8.0+: throw expressions which don't stop execution.
function nonStoppingThrowExpressions() {
$callable = fn() => throw new Exception();
$value = $myValue ? 'something' : throw new Exception();
$value = $myValue ?: throw new Exception();
$value = $myValue ? throw new Exception() : 'something';
$value = $nullableValue ?? throw new Exception();
$value ??= throw new Exception();
$condition && throw new Exception();
$condition || throw new Exception();
$condition and throw new Exception();
$condition or throw new Exception();
echo 'still executable as throw, in all of the above cases, is used as part of an expression';
throw new Exception();
echo 'non-executable';
}
// PHP 8.0+: throw expressions which do stop execution.
function executionStoppingThrowExpressionsA() {
$condition xor throw new Exception();
echo 'non-executable';
}
function executionStoppingThrowExpressionsB() {
throw $userIsAuthorized ? new ForbiddenException() : new UnauthorizedException();
echo 'non-executable';
}
function executionStoppingThrowExpressionsC() {
throw $condition1 && $condition2 ? new Exception1() : new Exception2();
echo 'non-executable';
}
function executionStoppingThrowExpressionsD() {
throw $exception ??= new Exception();
echo 'non-executable';
}
function executionStoppingThrowExpressionsE() {
throw $maybeNullException ?? new Exception();
echo 'non-executable';
}
function returnNotRequiredIgnoreCommentsA()
{
if ($something === TRUE) {
return /*comment*/;
}
echo 'foo';
return /*comment*/;
}
function returnNotRequiredIgnoreCommentsB()
{
echo 'foo';
return;
/*comment*/
}
$closure = function ()
{
echo 'foo';
return; // This return should be flagged as not required.
};
function fqnExitWithCodeAfter() {
do_something();
exit();
do_something_else();
}
function fqnExitInControlStructureWithCodeAfter() {
if(do_something()) {
die();
do_something_else();
}
do_something_else();
}