Avoid running phpt tests with coverage

When PHPUnit runs in coverage mode, it pre-loads all files. The files being
tested in the End2EndPhpt test suite need to be able to run code _before_ any
PHP_CodeSniffer classes are loaded, this isn't compatible. To avoid this, we
are moving this test suite to the 'end to end' test stage, where we do not run
code coverage.

Author: fredden

.github/workflows/end-to-end-tests.yml

@@ -48,6 +48,17 @@ jobs:
           ini-values: "error_reporting=-1, display_errors=On, display_startup_errors=On"
           coverage: none
 
+      # Install dependencies and handle caching in one go.
+      # @link https://github.com/marketplace/actions/install-php-dependencies-with-composer
+      - name: Install Composer dependencies
+        uses: "ramsey/composer-install@3cf229dc2919194e9e36783941438d17239e8520" # 3.1.1
+        with:
+          composer-options: ${{ matrix.php == '8.6' && '--ignore-platform-req=php+' || '' }}
+          custom-cache-suffix: $(date -u "+%Y-%m")
+
+      - name: 'PHPUnit: run end-to-end tests (phpt)'
+        run: php "vendor/bin/phpunit" -c phpunit-e2e.xml.dist --no-coverage
+
       - name: "Install bashunit"
         shell: bash
         run: |

phpunit-e2e.xml.dist

@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.2/phpunit.xsd"
+    backupGlobals="true"
+    beStrictAboutOutputDuringTests="true"
+    beStrictAboutTestsThatDoNotTestAnything="true"
+    convertErrorsToExceptions="true"
+    convertWarningsToExceptions="true"
+    convertNoticesToExceptions="true"
+    convertDeprecationsToExceptions="true"
+    >
+    <testsuites>
+        <testsuite name="End2EndPhpt">
+            <directory suffix=".phpt">tests/EndToEndPhpt/</directory>
+        </testsuite>
+    </testsuites>
+</phpunit>

phpunit-lte9.xml.dist

@@ -25,9 +25,6 @@
             <directory>./src/Standards/Squiz/Tests/</directory>
             <directory>./src/Standards/Zend/Tests/</directory>
         </testsuite>
-        <testsuite name="End2EndPhpt">
-            <directory suffix=".phpt">tests/EndToEndPhpt/</directory>
-        </testsuite>
     </testsuites>
 
     <groups>

phpunit.xml.dist

@@ -31,9 +31,6 @@
             <directory>./src/Standards/Squiz/Tests/</directory>
             <directory>./src/Standards/Zend/Tests/</directory>
         </testsuite>
-        <testsuite name="End2EndPhpt">
-            <directory suffix=".phpt">tests/EndToEndPhpt/</directory>
-        </testsuite>
     </testsuites>
 
     <groups>