Skip to content

Commit a153a51

Browse files
committed
Composer: clarify that the PHP libxml extension is required
The `simplexml` and `xmlwriter` extensions both need the `libxml` extension, so the requirement not being explicit was not problematic, as it was already enforced via the other two requirements. Still, better to be explicit. Includes adding the extension to the requirements check and the related tests.
1 parent c3eb74d commit a153a51

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
},
3636
"require": {
3737
"php": ">=7.2.0",
38+
"ext-libxml": "*",
3839
"ext-simplexml": "*",
3940
"ext-tokenizer": "*",
4041
"ext-xmlwriter": "*"

requirements.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ function checkRequirements()
4141

4242
$requiredExtensions = array(
4343
'tokenizer',
44+
'libxml',
4445
'xmlwriter',
4546
'SimpleXML',
4647
);

scripts/BuildRequirementsCheckMatrix.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public function getBuilds()
8282
*/
8383
private function getValidBuilds()
8484
{
85-
$extensions = ['minimal' => 'none, tokenizer, xmlwriter, SimpleXML'];
85+
$extensions = ['minimal' => 'none, tokenizer, libxml, xmlwriter, SimpleXML'];
8686

8787
$builds = [];
8888
foreach ($this->validPhp as $php) {
@@ -145,10 +145,10 @@ private function getInvalidPHPBuilds()
145145
private function getMissingExtensionsBuilds()
146146
{
147147
$extensions = [
148-
'missing tokenizer' => 'none, xmlwriter, SimpleXML',
149-
'missing xmlwriter' => ':xmlwriter',
150-
'missing SimpleXML' => ':SimpleXML',
151-
'missing both XML exts' => 'none, tokenizer',
148+
'missing tokenizer' => 'none, xmlwriter, SimpleXML',
149+
'missing xmlwriter' => ':xmlwriter',
150+
'missing SimpleXML' => ':SimpleXML',
151+
'missing all XML exts' => 'none, tokenizer',
152152
];
153153

154154
$builds = [];

0 commit comments

Comments
 (0)