Description

This PR improves code coverage for the Generic.ControlStructures.InlineControlStructure sniff. It is the last PR in a series discussed in #482 (review). It includes commit 8 from #482 and expands it, adding more tests. Including a test suggested by @jrfnl related to commit 3 (InlineControlStructureUnitTest.11.inc), which has been dropped.

There is still one line that is not covered by tests. I plan to address it in a separate PR. I still want to check a bit more, but I believe #880 made this line unreachable, and thus it can be removed.

I'm targeting 4.x instead of master as this PR builds on top of #880, which also target 4.x (see #880 (comment)).

Suggested changelog entry

N/A

Related issues/external references

Initially suggested in #482.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
  • This change is only breaking for integrators, not for external standards or end-users.
• Documentation improvement

PR checklist

• I have checked there is no other PR open for the same change.
• I have read the Contribution Guidelines.
• I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
• I have added tests to cover my changes.
• I have verified that the code complies with the projects coding standards.
• [Required for new sniffs] I have added XML documentation for the sniff.