Conversation
The ESLint project has released a new major, which is breaking test runs for PHPCS 3.x. As support for JS has been dropped in PHPCS 4.x anyway and the sniff is formally deprecated, investing time in making the tests cross-version compatible is not justifiable. This commit fixes the ESLint version used in the tests to the last release in the _previous_ major. This should get the tests passing again. Refs: * https://eslint.org/blog/2026/02/eslint-v10.0.0-released/
jrfnl
force-pushed
the
feature/fix-eslint-tests
branch
from
96d86c1 to
7e0cf97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ESLint project has released a new major, which is breaking test runs for PHPCS 3.x.
As support for JS has been dropped in PHPCS 4.x anyway and the sniff is formally deprecated, investing time in making the tests cross-version compatible is not justifiable.
This commit fixes the ESLint version used in the tests to the last release in the previous major. This should get the tests passing again.
Refs:
Suggested changelog entry
N/A