Skip to content

ExitCodeTest: add extra tests #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrfnl merged 1 commit into from
Mar 5, 2026
+67 −0
Merged

ExitCodeTest: add extra tests #1376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions tests/Core/Util/ExitCode/ExitCodeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,29 @@ public static function dataPhpcs()
'expected' => 3,
],

// Verify that when warnings or errors are suppressed, they don't affect the exit code.
'Only warnings, while ignoring warnings' => [
'extraArgs' => [
'-n',
'--sniffs=TestStandard.ExitCodes.Warning,TestStandard.ExitCodes.FixableWarning',
],
'expected' => 0,
],
'Only warnings, while warnings have severity 0' => [
'extraArgs' => [
'--warning-severity=0',
'--sniffs=TestStandard.ExitCodes.Warning,TestStandard.ExitCodes.FixableWarning',
],
'expected' => 0,
],
'Only errors, while errors have severity 0' => [
'extraArgs' => [
'--error-severity=0',
'--sniffs=TestStandard.ExitCodes.Error,TestStandard.ExitCodes.FixableError',
],
'expected' => 0,
],

// In both the below cases, we still have 1 fixable and 1 non-fixable issue which we need to take into account, so exit code = 3.
'Mix of errors and warnings, ignoring warnings for exit code' => [
'extraArgs' => [
Expand Down Expand Up @@ -491,6 +514,50 @@ public static function dataPhpcbf()
'expected' => 2,
],

// Verify that when warnings or errors are suppressed, they don't affect the exit code.
'Only warnings, while ignoring warnings' => [
'extraArgs' => [
'-n',
'--sniffs=TestStandard.ExitCodes.Warning,TestStandard.ExitCodes.FixableWarning',
],
'expected' => 0,
],
'Only warnings, while warnings have severity 0' => [
'extraArgs' => [
'--warning-severity=0',
'--sniffs=TestStandard.ExitCodes.Warning,TestStandard.ExitCodes.FixableWarning',
],
'expected' => 0,
],
'Only errors, while errors have severity 0' => [
'extraArgs' => [
'--error-severity=0',
'--sniffs=TestStandard.ExitCodes.Error,TestStandard.ExitCodes.FixableError',
],
'expected' => 0,
],
'Fixed all auto-fixable errors, non-auto-fixable warnings remain, but are ignored' => [
'extraArgs' => [
'-n',
'--sniffs=TestStandard.ExitCodes.FixableError,TestStandard.ExitCodes.Warning',
],
'expected' => 0,
],
'Fixed all auto-fixable errors, non-auto-fixable warnings remain, but warnings have severity 0' => [
'extraArgs' => [
'--warning-severity=0',
'--sniffs=TestStandard.ExitCodes.FixableError,TestStandard.ExitCodes.Warning',
],
'expected' => 0,
],
'Fixed all auto-fixable warnings, non-auto-fixable errors remain, but errors have severity 0' => [
'extraArgs' => [
'--error-severity=0',
'--sniffs=TestStandard.ExitCodes.FixableWarning,TestStandard.ExitCodes.Error',
],
'expected' => 0,
],

// In both the below cases, we still have 1 non-fixable issue which we need to take into account, so exit code = 2.
'Mix of errors and warnings, ignoring warnings for exit code' => [
'extraArgs' => [
Expand Down