Composer: clarify that the PHP libxml extension is required#1409
Open
Composer: clarify that the PHP libxml extension is required#1409
libxml extension is required#1409Conversation
The `simplexml` and `xmlwriter` extensions both need the `libxml` extension, so the requirement not being explicit was not problematic, as it was already enforced via the other two requirements. Still, better to be explicit. Includes adding the extension to the requirements check and the related tests.
16 tasks
rodrigoprimo
approved these changes
Apr 7, 2026
fredden
approved these changes
Apr 7, 2026
Member
fredden
left a comment
fredden
left a comment
There was a problem hiding this comment.
Thanks for this. To confirm, we are using PHP functions provided by the libxml extension (not just SimpleXML and XMLWriter), so listing this as one of our dependencies makes sense. The fact that this extension is already a dependency of those other two means that end users probably don't need to do anything differently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
simplexmlandxmlwriterextensions both need thelibxmlextension, so the requirement not being explicit was not problematic, as it was already enforced via the other two requirements.Still, better to be explicit.
Includes adding the extension to the requirements check and the related tests.
Suggested changelog entry
Clarified that
libxmlis a required PHP extensionRelated issues/external references
Related to #1392