Drop support for PHP < 7.2#281
Merged
Merged
Conversation
This commit comprehensively drops support for PHP < 7.2. Includes changing the security workflow to use the Composer `audit` command instead of the deprecated security checker CLI tool. Note: this commit does not change the supported PHPUnit versions (other than no longer needing PHPUnit 4.x - 7.x). This could possibly be done in a follow-up ticket, but to support PHPUnit >= 10, we'll need to find another way to debug failing tests as the test listener implementation we currently use, is no longer supported on PHPUnit >= 10. Closes 221
For the tests, all visibility modifiers have been set to `private`. For the `src`, all visibility modifiers have been set to `public` as anything else could be considered a BC-break. I suggest we open a ticket to change the constant visibility for the class constants in the `Plugin` class to `private` in the next major.
3 tasks
fredden
approved these changes
Mar 9, 2026
Member
Author
|
@Potherca Now the 1.2.1 release is out of the door, when you have some time, would be great to get this PR and the other two PRs reviewed, merged and released as v1.3.0. 🙏🏻 Note: the build for this PR will not pass as the branch protection settings will need to be updated, but it only makes sense to do this when we're ready to merge this PR (so as not to block other PRs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Drop support for PHP < 7.2
This commit comprehensively drops support for PHP < 7.2.
Includes changing the security workflow to use the Composer
auditcommand instead of the deprecated security checker CLI tool.Note: this commit does not change the supported PHPUnit versions (other than no longer needing PHPUnit 4.x - 7.x).
This could possibly be done in a follow-up ticket, but to support PHPUnit >= 10, we'll need to find another way to debug failing tests as the test listener implementation we currently use, is no longer supported on PHPUnit >= 10.
Closes #221
Modernize: add constant visibility
For the tests, all visibility modifiers have been set to
private.For the
src, all visibility modifiers have been set topublicas anything else could be considered a BC-break.I suggest we open a ticket to change the constant visibility for the class constants in the
Pluginclass toprivatein the next major.Modernize: use ::class
Suggested changelog entry
Removed: Support for PHP < 7.2