Fix code lens navigation for non-VS Code editors

Author: AJenbo

docs/CHANGELOG.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- **Code lens navigation.** Code lenses now work in Zed, Neovim, Emacs, and other editors. Previously the click command used a VS Code-specific API that other editors ignored.
 - **`@mixin` with union types.** `@mixin Foo|Bar` now correctly exposes members from all classes in the union. Previously only single-class mixins were recognized.
 - **`throw new` completion no longer offers non-instantiable types.** Interfaces, abstract classes, traits, and enums are now filtered out, matching the behavior of `new` completion. The `throw new` path also now filters to Throwable descendants only.
 - **Unified class name completion architecture.** `throw new` and `catch()` completion now use the same `build_class_name_completions` pipeline as `new`, `extends`, `implements`, etc. `throw new` uses a `ThrowNew` context (instantiable + Throwable) and `catch()`/`@throws` uses a `Catch` context (class or interface + Throwable). This gives both contexts the same affinity scoring, FQN shortening via use-map, namespace segment drill-down, deprecation flags, and consistent filtering. The separate `build_catch_class_name_completions` function has been removed.

src/code_lens.rs

@@ -70,30 +70,16 @@ impl Backend {
                     let icon = if proto.is_interface { "◆" } else { "↑" };
                     let title = format!("{} {}::{}", icon, proto.ancestor_name, method.name);
 
-                    // Build a URI with a fragment encoding the target
-                    // line and column so that `vscode.open` jumps to the
-                    // right position.  This avoids the `instanceof`
-                    // constraint errors that `editor.action.goToLocations`
-                    // and `editor.action.showReferences` trigger when
-                    // called from an LSP server without a companion
-                    // extension to convert plain JSON into VS Code class
-                    // instances.
-                    let fragment = format!(
-                        "L{},{}",
-                        proto.position.line + 1,
-                        proto.position.character + 1
-                    );
-                    let mut target_uri: Url = match proto.file_uri.parse() {
+                    let target_uri: Url = match proto.file_uri.parse() {
                         Ok(u) => u,
                         Err(_) => continue,
                     };
-                    target_uri.set_fragment(Some(&fragment));
 
-                    let command = Command {
+                    let command = self.build_code_lens_command(
                         title,
-                        command: "vscode.open".to_string(),
-                        arguments: Some(vec![serde_json::json!(target_uri)]),
-                    };
+                        target_uri,
+                        proto.position,
+                    );
 
                     lenses.push(CodeLens {
                         range,
@@ -322,6 +308,45 @@ impl Backend {
         None
     }
 
+    /// Build the LSP `Command` for a code lens that navigates to a target
+    /// location.
+    ///
+    /// Uses `editor.action.showReferences` (widely supported) by default,
+    /// and `vscode.open` when connected to a VS Code client.
+    fn build_code_lens_command(&self, title: String, uri: Url, position: Position) -> Command {
+        let client = self.client_name.lock();
+        if client.contains("Visual Studio Code") {
+            // VS Code: use vscode.open with a fragment for direct navigation.
+            let fragment = format!("L{},{}", position.line + 1, position.character + 1);
+            let mut target_uri = uri;
+            target_uri.set_fragment(Some(&fragment));
+            Command {
+                title,
+                command: "vscode.open".to_string(),
+                arguments: Some(vec![serde_json::json!(target_uri)]),
+            }
+        } else {
+            // All other editors: use editor.action.showReferences which is
+            // handled by most LSP clients (Zed, Neovim, Emacs, etc.).
+            let location = Location {
+                uri: uri.clone(),
+                range: Range {
+                    start: position,
+                    end: position,
+                },
+            };
+            Command {
+                title,
+                command: "editor.action.showReferences".to_string(),
+                arguments: Some(vec![
+                    serde_json::json!(uri),
+                    serde_json::json!(position),
+                    serde_json::json!([location]),
+                ]),
+            }
+        }
+    }
+
     /// Build a `Prototype` by locating the method's position in the
     /// ancestor's source file.
     fn build_prototype(

tests/integration/code_lens.rs

@@ -301,7 +301,7 @@ class Handler extends Base {
 // ─── Code Lens Command ─────────────────────────────────────────────────────
 
 #[test]
-fn lens_command_uses_vscode_open() {
+fn lens_command_uses_show_references_by_default() {
     let backend = create_test_backend();
     let content = r#"<?php
 class Parent_ {
@@ -317,16 +317,11 @@ class Child extends Parent_ {
 
     assert_eq!(lenses.len(), 1);
     let cmd = lenses[0].command.as_ref().unwrap();
-    assert_eq!(cmd.command, "vscode.open");
+    assert_eq!(cmd.command, "editor.action.showReferences");
     assert!(cmd.arguments.is_some());
     let args = cmd.arguments.as_ref().unwrap();
-    // Should have 1 argument: the URI with a fragment encoding the position
-    assert_eq!(args.len(), 1);
-    let uri_str = args[0].as_str().unwrap();
-    assert!(
-        uri_str.contains("#L"),
-        "URI should contain a #L fragment for the target position, got: {uri_str}"
-    );
+    // Should have 3 arguments: uri, position, locations[]
+    assert_eq!(args.len(), 3);
 }
 
 // ─── Multiple Interfaces ────────────────────────────────────────────────────