Fixes and brodens release

Author: DarkGhostHunter

.github/workflows/release.yml

@@ -28,11 +28,13 @@ jobs:
             os: ubuntu-latest
             archive: tar.gz
             cpu_version: x86-64-v3
+            suffix: modern
             rustflags: "-C target-cpu=x86-64-v3"
           - target: x86_64-unknown-linux-gnu
             os: ubuntu-latest
             archive: tar.gz
             cpu_version: x86-64-v4
+            suffix: avx512
             rustflags: "-C target-cpu=x86-64-v4"
 
           # --- Linux ARM ---
@@ -47,6 +49,20 @@ jobs:
             macos_sign: true
             cpu_version: x86-64-v2
             rustflags: "-C target-cpu=x86-64-v2"
+          - target: x86_64-apple-darwin
+            os: macos-latest
+            archive: tar.gz
+            macos_sign: true
+            cpu_version: x86-64-v3
+            suffix: modern
+            rustflags: "-C target-cpu=x86-64-v3"
+          - target: x86_64-apple-darwin
+            os: macos-latest
+            archive: tar.gz
+            macos_sign: true
+            cpu_version: x86-64-v4
+            suffix: avx512
+            rustflags: "-C target-cpu=x86-64-v4"
 
           # --- macOS ARM ---
           - target: aarch64-apple-darwin
@@ -64,11 +80,13 @@ jobs:
             os: windows-latest
             archive: zip
             cpu_version: x86-64-v3
+            suffix: modern
             rustflags: "-C target-cpu=x86-64-v3"
           - target: x86_64-pc-windows-msvc
             os: windows-latest
             archive: zip
             cpu_version: x86-64-v4
+            suffix: avx512
             rustflags: "-C target-cpu=x86-64-v4"
 
           # --- Windows ARM ---
@@ -99,8 +117,7 @@ jobs:
         env:
           RUSTFLAGS: ${{ matrix.rustflags || '' }}
           CARGO_PROFILE_RELEASE_OPT_LEVEL: "3"
-          CARGO_PROFILE_RELEASE_LTO: "fat"
-          CARGO_PROFILE_RELEASE_CODEGEN_UNITS: "1"
+          CARGO_PROFILE_RELEASE_LTO: "thin"
         run: cargo build --release --target ${{ matrix.target }}
 
       # --- macOS: import certificate and sign the binary ---
@@ -111,19 +128,27 @@ jobs:
           APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }}
           APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
         run: |
+          # Write the .p12 to disk
           echo "$APPLE_CERTIFICATE" | base64 --decode > certificate.p12
+          
+          # Create a temporary keychain so we don't touch the login keychain
           security create-keychain -p actions-keychain phpantom.keychain
           security set-keychain-settings -lut 21600 phpantom.keychain
           security unlock-keychain -p actions-keychain phpantom.keychain
+
+          # Import the certificate + private key
           security import certificate.p12 \
             -k phpantom.keychain \
             -P "$APPLE_CERTIFICATE_PASSWORD" \
             -T /usr/bin/codesign
           security list-keychain -d user -s phpantom.keychain
+
+          # Allow codesign to use the key without a UI prompt
           security set-key-partition-list \
             -S apple-tool:,apple: \
             -k actions-keychain \
             phpantom.keychain
+          
           rm certificate.p12
 
       - name: Sign binary (macOS)
@@ -146,6 +171,7 @@ jobs:
           APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
           APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
         run: |
+          # Zip just for submission — notarytool requires an archive
           ditto -c -k --keepParent \
             target/${{ matrix.target }}/release/phpantom_lsp \
             phpantom_lsp-notarize.zip
@@ -170,24 +196,24 @@ jobs:
         run: |
           cd target/${{ matrix.target }}/release
           # Appends the cpu_version (e.g., -x86-64-v3) to the archive name if it exists
-          SUFFIX="${{ matrix.cpu_version && format('-{0}', matrix.cpu_version) || '' }}"
+          SUFFIX="${{ matrix.suffix && format('-{0}', matrix.suffix) || '' }}"
           tar czf ../../../phpantom_lsp-${{ matrix.target }}${SUFFIX}.tar.gz phpantom_lsp
           cd ../../..
 
       - name: Package (windows)
         if: matrix.archive == 'zip'
         shell: pwsh
         run: |
-          $suffix = "${{ matrix.cpu_version }}" ? "-${{ matrix.cpu_version }}" : ""
+          $suffix = "${{ matrix.suffix }}" ? "-${{ matrix.suffix }}" : ""
           Compress-Archive `
             -Path "target/${{ matrix.target }}/release/phpantom_lsp.exe" `
             -DestinationPath "phpantom_lsp-${{ matrix.target }}$suffix.zip"
 
       - name: Upload artifact
         uses: actions/upload-artifact@v4
         with:
-          name: phpantom_lsp-${{ matrix.target }}-${{ matrix.cpu_version || 'native' }}
-          path: phpantom_lsp-${{ matrix.target }}${{ matrix.cpu_version && format('-{0}', matrix.cpu_version) || '' }}.${{ matrix.archive }}
+          name: phpantom_lsp-${{ matrix.target }}-${{ matrix.suffix || '' }}
+          path: phpantom_lsp-${{ matrix.target }}${{ matrix.suffix && format('-{0}', matrix.suffix) || '' }}.${{ matrix.archive }}
 
   release:
     name: Create Release