Move named argument to use symbol map

Author: AJenbo

docs/CHANGELOG.md

@@ -11,8 +11,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - **Docblock navigation.** Go-to-definition and hover now work on class names inside callable type annotations (`\Closure(Request): Response`), and Ctrl+Click on object shape properties (`$profile->name` from `@return object{name: string}`) jumps to the key inside the docblock.
 
+### Changed
+
+- **Named-argument completion uses symbol map.** Detection now uses precomputed `CallSite` data from the AST-based symbol map as the primary path, falling back to text scanning for broken ASTs. This correctly handles chain-resolution on `$this->prop->method(`, `$obj->first()->second(`, `(new Foo())->bar(`, and strings containing parentheses.
+- **Member-access completion uses symbol map.** `try_member_access_completion` now consults the symbol map's `MemberAccess` entries before falling back to text-based subject extraction. This improves accuracy for `(new Foo)->`, call-result chains, array access chains, and null-safe chains when the parser successfully recovers the AST.
+
 ### Fixed
 
+- **Named-argument resolution for non-variable subjects.** `resolve_named_arg_params` now routes all instance-method subjects (bare class names, chain results) through `resolve_target_classes` instead of returning empty results when the subject does not start with `$`. The same fix is applied to static-method resolution, which now falls back to variable/chain resolution when the class name is not found directly.
 - **GTD for `@method`/`@property` on interfaces.** Go-to-definition now walks implemented interfaces (own and from parents) before checking `@mixin` classes, so virtual members declared on interfaces resolve correctly.
 - **`?->` null-safe chain resolution.** The `rfind("->")` split incorrectly matched the `->` inside `?->`, leaving a trailing `?` on the left-hand side. Fixed at all seven call sites across resolver, text resolution, handler, foreach resolution, and signature help.
 - **`(new Canvas())->easel` property access.** Parenthesized `new` expressions on the left side of `->` now resolve correctly for variable type inference.

docs/todo.md

@@ -16,67 +16,13 @@ Each item carries two ratings:
 
 ---
 
-<!-- ============================================================ -->
-<!--  TIER 0 — CRITICAL (infrastructure refactors)                -->
-<!-- ============================================================ -->
-
-## Critical
-
-### 1. Named-argument completion: migrate to symbol map
-**Impact: Critical · Effort: Low**
-
-`detect_named_arg_context` in `named_args.rs` uses `find_enclosing_open_paren`
-and `extract_call_expression` (character-level backward scanning) to detect
-which function or method call the cursor is inside. This suffers from chain-
-resolution failures on `$this->prop->method(`, `$obj->first()->second(`,
-`(new Foo())->bar(`, and strings containing parentheses.
-
-The `CallSite` vector and `find_enclosing_call_site` are now available in
-`SymbolMap` (added during the signature help refactor). Named-arg completion
-can use `find_enclosing_call_site` as its primary detection path and fall
-back to the text scanner for broken ASTs, mirroring the approach already
-working in signature help.
-
-`resolve_named_arg_params` also has an `else { vec![] }` bug: when the
-subject of a `->` call doesn't start with `$` (e.g. a chain result or
-bare class name), it returns no parameters. The fix is the same one
-applied to signature help's `resolve_callable`: route all subjects
-through `resolve_target_classes` instead of guarding on `starts_with('$')`.
-
----
-
-### 2. Completion member access: add symbol-map primary path
-**Impact: Critical · Effort: Medium**
-
-`try_member_access_completion` calls `extract_completion_target` (in
-`target.rs`), which uses `collapse_continuation_lines`,
-`extract_arrow_subject`, and `extract_double_colon_subject` from
-`subject_extraction.rs`. This is pure character-level backward scanning
-with no symbol-map involvement (confirmed: zero references to
-`symbol_map` in the entire `completion/` directory).
-
-Hover and go-to-definition already use `SymbolMap::lookup` to get a
-pre-extracted `MemberAccess { subject_text, member_name, is_static,
-is_method_call }` from the AST. Completion should adopt the same
-"symbol map primary, text fallback" pattern so it benefits from the
-AST's correct handling of `(new Foo())->`, call-result chains, array
-access chains, and null-safe chains.
-
-The main challenge is that completion fires while the user is actively
-typing, so the AST is frequently broken at the cursor. The text scanner
-is more resilient in that scenario, which is why it should remain as a
-fallback rather than being removed. The symbol-map path would improve
-accuracy for all cases where the parser successfully recovers.
-
----
-
 <!-- ============================================================ -->
 <!--  TIER 1 — HIGH IMPACT                                        -->
 <!-- ============================================================ -->
 
 ## High Impact
 
-### 3. Pipe operator (PHP 8.5)
+### 1. Pipe operator (PHP 8.5)
 **Impact: High · Effort: Low**
 
 PHP 8.5 introduced the pipe operator (`|>`):
@@ -102,7 +48,7 @@ callable syntax (`htmlspecialchars(...)`), reuse the existing
 
 ---
 
-### 4. Function-level `@template` generic resolution
+### 2. Function-level `@template` generic resolution
 **Impact: High · Effort: Medium**
 
 `MethodInfo` has `template_params` and `template_bindings` fields that
@@ -203,7 +149,7 @@ manifestation of this gap.
 
 ---
 
-### 5. Parse and resolve `($param is T ? A : B)` return types
+### 3. Parse and resolve `($param is T ? A : B)` return types
 **Impact: High · Effort: Medium**
 
 PHPStan's stubs use conditional return type syntax in docblocks:
@@ -242,7 +188,7 @@ extend the existing `ConditionalReturnType` infrastructure.
 
 ---
 
-### 6. Warn when composer.json is missing or classmap is not optimized
+### 4. Warn when composer.json is missing or classmap is not optimized
 **Impact: High · Effort: Medium**
 
 PHPantom relies on Composer artifacts (`vendor/composer/autoload_classmap.php`,
@@ -317,7 +263,7 @@ For the non-optimized classmap case, offer action buttons:
 
 ---
 
-### 7. Find References (`textDocument/references`)
+### 5. Find References (`textDocument/references`)
 **Impact: High · Effort: Medium-High**
 
 Can't find all usages of a symbol. The precomputed `SymbolMap` (built
@@ -341,7 +287,7 @@ variable within its scope" without re-parsing.
 
 ## Medium-High Impact
 
-### 8. File system watching for vendor and project changes
+### 6. File system watching for vendor and project changes
 **Impact: Medium-High · Effort: Medium**
 
 PHPantom loads Composer artifacts (classmap, PSR-4 mappings, autoload
@@ -399,7 +345,7 @@ supports glob patterns like `**/vendor/composer/autoload_*.php`.
 
 ## Medium Impact
 
-### 9. No reverse jump: implementation → interface method declaration
+### 7. No reverse jump: implementation → interface method declaration
 **Impact: Medium · Effort: Low**
 
 Go-to-implementation lets you jump from an interface method to its concrete
@@ -416,7 +362,7 @@ target.
 
 ---
 
-### 10. Suppress GTD on parameter variable names and class declaration names
+### 8. Suppress GTD on parameter variable names and class declaration names
 **Impact: Medium · Effort: Low**
 
 Go-to-definition fires on parameter variable names (`$supplier`, `$country`)
@@ -452,7 +398,7 @@ expect `None` instead.
 
 ---
 
-### 11. `BackedEnum::from()` / `::tryFrom()` return type refinement
+### 9. `BackedEnum::from()` / `::tryFrom()` return type refinement
 **Impact: Medium · Effort: Low**
 
 When calling `MyEnum::from($value)` or `MyEnum::tryFrom($value)`,
@@ -469,14 +415,14 @@ See `BackedEnumFromMethodDynamicReturnTypeExtension` in PHPStan.
 
 ---
 
-### 12. Document Symbols (`textDocument/documentSymbol`)
+### 10. Document Symbols (`textDocument/documentSymbol`)
 **Impact: Medium · Effort: Low**
 
 No outline view. Editors can't show a file's class/method/property structure.
 
 ---
 
-### 13. Workspace Symbols (`workspace/symbol`)
+### 11. Workspace Symbols (`workspace/symbol`)
 **Impact: Medium · Effort: Low-Medium**
 
 Can't search for classes/functions across the project. The `ast_map`
@@ -488,7 +434,7 @@ LSP `Location`s.
 
 ---
 
-### 14. No go-to-definition for built-in (stub) functions and constants
+### 12. No go-to-definition for built-in (stub) functions and constants
 **Impact: Medium · Effort: Medium**
 
 Clicking on a built-in function name like `array_map`, `strlen`, or
@@ -510,7 +456,7 @@ limitation.
 
 ---
 
-### 15. Property hooks (PHP 8.4)
+### 13. Property hooks (PHP 8.4)
 **Impact: Medium · Effort: Medium**
 
 PHP 8.4 introduced property hooks (`get` / `set`):
@@ -545,7 +491,7 @@ scopes, and parse the set-visibility modifier into a new
 
 ---
 
-### 16. Narrow types of `&$var` parameters after function calls
+### 14. Narrow types of `&$var` parameters after function calls
 **Impact: Medium · Effort: Medium**
 
 When a function takes a parameter by reference, the variable's type
@@ -574,7 +520,7 @@ extension) or use a built-in map for known functions.
 
 ---
 
-### 17. SPL iterator generic stubs
+### 15. SPL iterator generic stubs
 **Impact: Medium · Effort: Medium**
 
 PHPStan's `iterable.stub` provides full `@template TKey` /
@@ -595,7 +541,7 @@ certainly missing these generic annotations.  We should either:
 
 ---
 
-### 18. Partial result streaming via `$/progress`
+### 16. Partial result streaming via `$/progress`
 **Impact: Medium · Effort: Medium-High**
 
 The LSP spec (3.17) allows requests that return arrays — such as
@@ -675,7 +621,7 @@ developer arrive before vendor matches, even within a single phase.
 
 ---
 
-### 19. Rename (`textDocument/rename`)
+### 17. Rename (`textDocument/rename`)
 **Impact: Medium · Effort: Medium-High**
 
 No rename refactoring support. Rename builds on find-references (§8) —
@@ -690,7 +636,7 @@ position without text scanning.
 
 ---
 
-### 20. Array functions needing new code paths
+### 18. Array functions needing new code paths
 **Impact: Medium · Effort: High**
 
 These functions have return type semantics that don't fit into either
@@ -729,7 +675,7 @@ These functions have return type semantics that don't fit into either
 
 ## Low-Medium Impact
 
-### 21. Asymmetric visibility (PHP 8.4)
+### 19. Asymmetric visibility (PHP 8.4)
 **Impact: Low-Medium · Effort: Low**
 
 Separate from property hooks, PHP 8.4 allows asymmetric visibility on
@@ -759,7 +705,7 @@ is just to store the value; context-aware filtering can follow later.
 
 ---
 
-### 22. `str_contains` / `str_starts_with` / `str_ends_with` → non-empty-string narrowing
+### 20. `str_contains` / `str_starts_with` / `str_ends_with` → non-empty-string narrowing
 **Impact: Low-Medium · Effort: Low**
 
 When `str_contains($haystack, $needle)` appears in a condition and
@@ -776,7 +722,7 @@ See `StrContainingTypeSpecifyingExtension` in PHPStan.
 
 ---
 
-### 23. `count` / `sizeof` comparison → non-empty-array narrowing
+### 21. `count` / `sizeof` comparison → non-empty-array narrowing
 **Impact: Low-Medium · Effort: Low**
 
 `if (count($arr) > 0)` or `if (count($arr) >= 1)` narrows `$arr` to
@@ -788,7 +734,7 @@ branches in `TypeSpecifier::specifyTypesInCondition`.
 
 ---
 
-### 24. Go-to-definition for array shape keys via bracket access
+### 22. Go-to-definition for array shape keys via bracket access
 **Impact: Low · Effort: Medium**
 
 Array shape keys accessed via bracket notation (`$status['code']`)
@@ -813,7 +759,7 @@ key inside the matching `array{…}` annotation.
 
 ## Low Impact
 
-### 25. Short-name collisions in `find_implementors`
+### 23. Short-name collisions in `find_implementors`
 **Impact: Low · Effort: Low**
 
 `class_implements_or_extends` matches interfaces by both short name and
@@ -829,7 +775,7 @@ before comparison.
 
 ---
 
-### 26. Fiber type resolution
+### 24. Fiber type resolution
 **Impact: Low · Effort: Low**
 
 `Generator<TKey, TValue, TSend, TReturn>` has dedicated support for
@@ -844,7 +790,7 @@ Generator extraction in `docblock/types.rs`.
 
 ---
 
-### 27. Non-empty-string propagation through string functions
+### 25. Non-empty-string propagation through string functions
 **Impact: Low · Effort: Low**
 
 PHPStan tracks `non-empty-string` through string-manipulating
@@ -862,7 +808,7 @@ See `NonEmptyStringFunctionsReturnTypeExtension` in PHPStan.
 
 ---
 
-### 28. `Closure::bind()` / `Closure::fromCallable()` return type preservation
+### 26. `Closure::bind()` / `Closure::fromCallable()` return type preservation
 **Impact: Low · Effort: Low-Medium**
 
 Variables holding closure literals, arrow functions, and first-class
@@ -878,7 +824,7 @@ See `ClosureBindDynamicReturnTypeExtension` and
 
 ---
 
-### 29. Remove deprecated text-search fallbacks
+### 27. Remove deprecated text-search fallbacks
 **Impact: Low · Effort: Medium**
 
 The go-to-definition subsystem now uses the precomputed `SymbolMap` as
@@ -910,7 +856,7 @@ would let that deprecated function be removed entirely.
 
 ---
 
-### 30. Non-array functions with dynamic return types
+### 28. Non-array functions with dynamic return types
 **Impact: Low · Effort: High**
 
 PHPStan also provides dynamic return type extensions for many non-array
@@ -941,7 +887,7 @@ return types (less impactful for class-based completion).
 
 ---
 
-### 31. Language construct signature help and hover
+### 29. Language construct signature help and hover
 **Impact: Low · Effort: Low**
 
 PHP language constructs that use parentheses (`unset()`, `isset()`, `empty()`,
@@ -958,22 +904,22 @@ need a similar hardcoded lookup.
 
 ---
 
-### 32. Diagnostics
+### 30. Diagnostics
 **Impact: Low (large scope) · Effort: Very High**
 
 No error reporting (undefined methods, type mismatches, etc.).
 
 ---
 
-### 33. Code Actions
+### 31. Code Actions
 **Impact: Low · Effort: Very High**
 
 No quick fixes or refactoring suggestions. No `codeActionProvider` in
 `ServerCapabilities`, no `textDocument/codeAction` handler, and no
 `WorkspaceEdit` generation infrastructure beyond trivial `TextEdit`s for
 use-statement insertion.
 
-#### 33a. Extract Function refactoring
+#### 31a. Extract Function refactoring
 
 Select a range of statements inside a method/function and extract them into a
 new function. The LSP would need to: