Fix memory audit

Author: AJenbo

docs/todo.md

@@ -114,7 +114,6 @@ unlikely to move the needle for most users.
 | D15 | [Unused parameter diagnostic](todo/diagnostics.md#d15-unused-parameter-diagnostic)                                                                                          | Low         | Low         |
 |     | **[Bug Fixes](todo/bugs.md)**                                                                                                                                               |             |             |
 | B1  | [Rename can build edits from a symbol map that predates the buffer](todo/bugs.md#b1-rename-can-build-edits-from-a-symbol-map-that-predates-the-buffer)                       | Medium-High | Low-Medium  |
-| B2  | [`mem-audit` feature build fails: `Ustr::capacity()` does not exist](todo/bugs.md#b2-mem-audit-feature-build-fails-ustrcapacity-does-not-exist)                              | Low         | Low         |
 |     | **[Code Actions](todo/actions.md)**                                                                                                                                         |             |             |
 | A40 | [Generate method from call](todo/actions.md#a40-generate-method-from-call)                                                                                                  | Medium-High | Medium      |
 | A41 | [Create class from non-existing name](todo/actions.md#a41-create-class-from-non-existing-name)                                                                              | Medium      | Medium      |

docs/todo/bugs.md

@@ -41,39 +41,3 @@ Note that the cross-file paths need slightly more than linked editing
 did: they read maps for files other than the request URI, so each one
 must be checked against *that* file's content, not the buffer the
 request arrived on.
-
-## B2 `mem-audit` feature build fails: `Ustr::capacity()` does not exist
-
-`cargo build --features mem-audit` fails on `main` (reproduced before
-any local changes, via `git stash`):
-
-```
-error[E0599]: no method named `capacity` found for reference `&Ustr` in the current scope
-   --> src/mem_audit.rs:1269:27
-    |
-1269 |                 sym.add(k.capacity());
-    |                           ^^^^^^^^ method not found in `&Ustr`
-
-error[E0599]: no method named `capacity` found for reference `&Ustr` in the current scope
-   --> src/mem_audit.rs:1271:34
-    |
-1271 |                 member_idx.add(k.capacity());
-    |                                  ^^^^^^^^ method not found in `&Ustr`
-```
-
-`k` in both call sites is a `Ustr` (interned string handle from the
-`ustr` crate) used as a hash map key, and the audit code is calling
-`.capacity()` on it to account for heap bytes the way it does for
-`String`/`Box<str>` keys elsewhere in the same file. `Ustr` has no
-`capacity()` method — it is a pointer into a global intern table, not
-an owned allocation, so the right accounting is either to treat it as
-zero marginal heap cost (the string data is shared and already counted
-once wherever it's interned) or to look up whatever `ustr` exposes for
-the underlying byte length, not capacity.
-
-The current profile (dev, `cargo build --lib`) never builds this
-feature, so normal development and `cargo test` are unaffected. It only
-surfaces when actually running the memory-audit binary, which is
-presumably why it went unnoticed. Fix by correcting the two call sites
-in `src/mem_audit.rs` to match whatever the installed `ustr` version's
-API actually provides.

src/mem_audit.rs

@@ -1263,12 +1263,10 @@ pub(crate) fn report(backend: &Backend, runner_content_bytes: usize) {
             for sp in &sm.spans {
                 sym.add(sp.kind.audit_heap());
             }
-            sym += map_buckets::<String, Vec<usize>>(sm.member_access_indices.capacity());
-            member_idx += map_buckets::<String, Vec<usize>>(sm.member_access_indices.capacity());
-            for (k, v) in &sm.member_access_indices {
-                sym.add(k.capacity());
+            sym += map_buckets::<Atom, Vec<usize>>(sm.member_access_indices.capacity());
+            member_idx += map_buckets::<Atom, Vec<usize>>(sm.member_access_indices.capacity());
+            for v in sm.member_access_indices.values() {
                 sym.add(v.capacity() * size_of::<usize>());
-                member_idx.add(k.capacity());
                 member_idx.add(v.capacity() * size_of::<usize>());
             }
             sym.add(sm.var_defs.capacity() * size_of::<crate::symbol_map::VarDefSite>());