Extracted shared function

Author: AJenbo

docs/CHANGELOG.md

@@ -40,6 +40,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- **Static method calls resolve return types as accurately as instance calls.** `Foo::bar()` previously missed inference that `$foo->bar()` already had: return types behind a `@phpstan-type` alias, inherited return types substituted through a generic interface or trait, and the `__callStatic()` magic-method fallback. These now resolve the same way for both call styles.
 - **Facade static calls keep concrete method return types.** Static calls on Laravel-style facades now resolve missing methods through `getFacadeAccessor()` and facade `@mixin` targets before falling back to `__callStatic()`, so values like `Driver::details()` keep the concrete provider method return type instead of degrading to the facade's broad magic-call return. Contributed by @calebdw.
 - **`class-string<static>` parameters no longer reject sibling subclass constants.** Static helper calls from a shared base class that pass concrete `::class` constants for sibling subclasses no longer report false argument-type mismatches against `class-string<static>`. Contributed by @calebdw.
 - **Built-in PHP classes shadowed by vendor polyfills resolve to the real definition.** When an installed package ships a polyfill for a PHP built-in (for example symfony/polyfill-php84's `RoundingMode`), resolution sometimes picked the polyfill's legacy pre-enum declaration instead of the built-in, turning enum cases into plain int constants and reporting false "expects RoundingMode, got int" argument mismatches. Which declaration won could change from one run to the next, making whole-project analysis results nondeterministic. Global names of built-in classes now always resolve to the bundled PHP definition, and classes discovered inside phar archives are indexed in a stable order.

docs/todo/refactor.md

@@ -220,35 +220,27 @@ Each item must include:
 copies-for-another-code-path that should collapse onto one
 implementation (do this after — or as part of — the splits above):
 
-1. **Call return-type wrappers.** `resolve_rhs_method_call_inner` /
-   `resolve_rhs_static_call` / `resolve_rhs_function_call`
-   (`rhs_resolution/calls.rs`) call into
-   `Backend::resolve_method_return_types_with_args`
-   (`call_resolution/return_types.rs`) but each re-implements the
-   surrounding self/static substitution, union-owner expansion, and
-   scalar fallbacks. Consolidate the pre/post logic into one shared
-   entry point.
-2. **Callable-param inference.** The `*_fw`-suffixed family in
+1. **Callable-param inference.** The `*_fw`-suffixed family in
    `forward_walk/` parallels the logic in
    `completion/variable/closure_resolution.rs`. The suffix itself marks
    a copy; unify them.
-3. **`$this`/`self`/`static` resolution.** ~32 call sites spread across
+2. **`$this`/`self`/`static` resolution.** ~32 call sites spread across
    `util.rs` (`is_self_or_static`, `resolve_class_keyword`),
    `call_resolution/callable_target.rs` (`resolve_class_name_keyword`),
    `resolver/mod.rs` (`resolve_static_owner_class`), and `forward_walk/`
    (`seed_this`), plus hand-rolled `== "$this"` checks. Back them with
    one helper module.
-4. **Subclass checks.** `is_subclass_of` (`forward_walk/`),
+3. **Subclass checks.** `is_subclass_of` (`forward_walk/`),
    `is_type_subclass_of` and `is_valid_virtual_narrowing`
    (`call_resolution/return_types.rs`), and `util::is_subtype_of*`
    overlap; route through the `util`/`php_type` versions.
-5. **Property-assignment scanning.** The
+4. **Property-assignment scanning.** The
    `find_*_this_property_assignment*` family
    (`rhs_resolution/property_access.rs`) and the
    `walk_property_narrowing_*` family (`resolver/property_narrowing.rs`)
    walk class members and statements with near-identical skeletons for
    different outputs. Share the traversal.
-6. **Argument-text extraction.** `extract_argument_texts_fw` /
+5. **Argument-text extraction.** `extract_argument_texts_fw` /
    `extract_first_arg_string_fw` (`forward_walk/`) vs
    `extract_first_arg_text` / `resolve_inline_arg_raw_type`
    (`call_resolution/arg_type_resolution.rs`) vs