Faster diagnostics on large projects

Author: AJenbo

docs/CHANGELOG.md

@@ -46,6 +46,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **Lower memory use in the cross-file reference index.** The index backing Find References and the reference-count inlay hints now keeps only the distinct files and counts each symbol actually needs, instead of one entry per matching location plus never-read position data. On large projects this removes millions of short-lived allocations and shrinks the index to a fraction of its previous size, with no change to Find References or inlay hint results.
 - **Lower memory use for method lookups.** Each resolved class's method name index is now a sorted list searched with binary search instead of a hash map, using about a third of the memory for the same lookup speed. On large Laravel projects, where the resolved-class cache holds thousands of these indexes, this measurably shrinks total memory use.
 - **Lower memory use for member access spans.** The subject text recorded for every `->`/`::` access (e.g. `$this` in `$this->save()`) no longer allocates a string when it is a plain slice of the source, which covers the vast majority of accesses in typical PHP code. It now reuses the file's own bytes instead, with an allocation only for the rarer cases (chained calls, `new` expressions) where the recorded text differs from the source.
+- **Faster diagnostics on large projects.** Several diagnostic checks (by-reference parameter detection, the `Stringable`-to-`string` acceptance check, and `model-property<Model>` literal validation) now read a class's inheritance from the resolved-class cache instead of re-merging traits, parent classes, and generics from scratch on every call. On large Laravel projects this removed a measurable share of the diagnostic pass's CPU time, and as a side effect these checks now also see interface-declared members (e.g. a `__toString` declared only on an implemented interface).
 
 ### Removed
 

src/class_lookup.rs

@@ -459,7 +459,11 @@ pub(crate) fn is_subtype_of_typed(
         if let Some(model_name) = g.args[0].base_name()
             && let Some(cls) = class_loader(model_name)
         {
-            let resolved = crate::inheritance::resolve_class_with_inheritance(&cls, class_loader);
+            let resolved = crate::virtual_members::resolve_class_fully_maybe_cached(
+                &cls,
+                class_loader,
+                crate::virtual_members::active_resolved_class_cache(),
+            );
             return resolved.properties.iter().any(|p| &*p.name == prop_name)
                 || crate::virtual_members::laravel::where_property::collect_column_names(&cls)
                     .iter()

src/diagnostics/type_errors/compatibility.rs

@@ -289,7 +289,11 @@ pub(crate) fn is_type_compatible(
     if param_type.is_string_type() && arg_type.is_object_like() {
         if let Some(class_name) = arg_type.base_name() {
             if let Some(cls) = class_loader(class_name) {
-                let merged = crate::inheritance::resolve_class_with_inheritance(&cls, class_loader);
+                let merged = crate::virtual_members::resolve_class_fully_maybe_cached(
+                    &cls,
+                    class_loader,
+                    crate::virtual_members::active_resolved_class_cache(),
+                );
                 let implements_stringable =
                     crate::class_lookup::is_subtype_of(&cls, "Stringable", class_loader);
                 let has_to_string = merged.get_method_ci("__toString").is_some();
@@ -399,8 +403,11 @@ pub(crate) fn is_type_compatible(
             if let Some(model_name) = args[0].base_name()
                 && let Some(cls) = class_loader(model_name)
             {
-                let resolved =
-                    crate::inheritance::resolve_class_with_inheritance(&cls, class_loader);
+                let resolved = crate::virtual_members::resolve_class_fully_maybe_cached(
+                    &cls,
+                    class_loader,
+                    crate::virtual_members::active_resolved_class_cache(),
+                );
                 let found = resolved.properties.iter().any(|p| &*p.name == prop_name)
                     || crate::virtual_members::laravel::where_property::collect_column_names(&cls)
                         .iter()

src/diagnostics/undefined_variables/mod.rs

@@ -167,9 +167,11 @@ impl Backend {
                 let cls = self
                     .find_or_load_class(&fqn)
                     .or_else(|| self.find_or_load_class(class_name))?;
-                let merged = crate::inheritance::resolve_class_with_inheritance(&cls, &|name| {
-                    self.find_or_load_class(name)
-                });
+                let merged = crate::virtual_members::resolve_class_fully_maybe_cached(
+                    &cls,
+                    &|name| self.find_or_load_class(name),
+                    Some(&self.resolved_class_cache),
+                );
                 let method = merged.get_method(method_name)?;
                 let positions: Vec<usize> = method
                     .parameters
@@ -185,9 +187,11 @@ impl Backend {
                 let cls = self
                     .find_or_load_class(&fqn)
                     .or_else(|| self.find_or_load_class(class_name))?;
-                let merged = crate::inheritance::resolve_class_with_inheritance(&cls, &|name| {
-                    self.find_or_load_class(name)
-                });
+                let merged = crate::virtual_members::resolve_class_fully_maybe_cached(
+                    &cls,
+                    &|name| self.find_or_load_class(name),
+                    Some(&self.resolved_class_cache),
+                );
                 let ctor = merged.get_method("__construct")?;
                 let positions: Vec<usize> = ctor
                     .parameters
@@ -203,9 +207,11 @@ impl Backend {
                 let cls = self
                     .find_or_load_class(&fqn)
                     .or_else(|| self.find_or_load_class(class_name))?;
-                let merged = crate::inheritance::resolve_class_with_inheritance(&cls, &|name| {
-                    self.find_or_load_class(name)
-                });
+                let merged = crate::virtual_members::resolve_class_fully_maybe_cached(
+                    &cls,
+                    &|name| self.find_or_load_class(name),
+                    Some(&self.resolved_class_cache),
+                );
                 let method = merged.get_method(method_name)?;
                 let positions: Vec<usize> = method
                     .parameters