How do I make this work in Cursor?

[CicerBro]

Generic LSP Client v2 isn't available in the Cursor marketplace.

[AJenbo]

Have you tried downloading the .vsix from the VS Code market place and see if it work in Cursor?

[AJenbo]

So I pointed Codex at this repo and the Zed extension and had it whip up a VSIX. Works in Cursor.

Thanks that's helpful since I don't have Cursor installed and it's a bit of effort to test and setup each editor.

I did noticed things that worked in Intelephense but not here. Like I cant CMD + Click many methods and go to the method definition, I can on the class the method is in, but often not the method.

Could you please make sure you tested a build of the latest main, a lot of issues have been fixed and we are close to a new release. It would be good to know if this one has been solved. If not then if you can please provide an example, preferably a repo that makes it easy for me to replicate the issue.

Another thing I noticed, is that my theme is working differently. consts are blueish now, they used to be white. Same for namespaces, the prefixes used to be white App\Mail\ and then the class name would be yellow PasswordResetEmail. I am guessing because the LSP doesn't differentiate and Intelephense/Cursor/VSCode (TextMate) does?

This is probably down to differences in Semantic Tokens, some LSP provides them, some don't some are different, some editors use a build in parser for highlighting, just use the LSP or a combination. But there's often a setting where you can choose what it should do with it.
I will add that I'm currently working on figuring out what tree-sitter does differently with the import names cause I'm not satisfied with that one either, but it was needed for highlighting in Blade files.

[CicerBro]

Ok good to know. I just grabbed the latest release: 0.70. If you meant something newer, is there a dev build anywhere or do I need to compile from scratch?

[AJenbo]

You would need to compile it your self. You can see here what has been fixed / added / changed: https://github.com/AJenbo/phpantom_lsp/blob/main/docs/CHANGELOG.md#unreleased since last release.

[CicerBro]

Ok I build the master branch but still the same thing.

[Info  - 20:06:35] PHPantom v0.7.0-173-g807e33d-dirty: PHP 8.5, 17169 symbols from composer+scan, stubs master@517b9ad1ad

I hover a method and it will show a popup box with something like:

<?php
namespace Filament\Notifications;
class Notification {
    public function send(): static;

but when I CMD + click the method, nothing happens. I do see this in the console when pressing down CMD (before clicking)

[Info  - 20:09:01] Opened file: file:///Users/XXXX/Code/project_name/vendor/filament/notifications/src/Concerns/HasStatus.php
[Info  - 20:09:01] Closed file: file:///Users/XXXX/Code/project_name/vendor/filament/notifications/src/Concerns/HasStatus.php

$invite = UserInvite::findValidPendingByToken($code);

Clicking UserInvite works (small 1-2 second delay), it opens the class. Clicking √ does nothing except show Opened/Closed file in console. Clicking methods within the same class works however, like $this->method();

Sometimes it will actually work, but seems very random. Like I restarted the LSP once more and suddenly I could actually click the method and go there, then I flip through a few files, come back and it doesn't :-)

I also noticed when clicking methods sometimes it tries to open a file called .

I was used to hovering it and seeing one or more places where this was defined. Something like this pops up with Intelephense after hovering the method (don't ask me why it's showing twice lol):

And CMD + Clicking it:

Don't want to pile up too much haha, but I also am missing builtin php function signatures when hovering. Probably an Intelephense feature (always thought it was a VSCode thing):

And I am seeing PHP-CS errors in my Problems tab now even though with PHPAntom off and Intelephense on, these are not shown. Maybe Intelephense overrides some other extensions idk.

[AJenbo]

I have fixed an issue that could be what you are describing, but if you are still having it then please provide a way that I can reproduce this, if you can share you repo then make a minimal one where the issue can be reproduced.

And I am seeing PHP-CS errors in my Problems tab now even though with PHPAntom off and Intelephense on, these are not shown. Maybe Intelephense overrides some other extensions idk.

PHPantom will forward phpcs issues to the IDE, Intelephense probably dosn't support this.

[CicerBro]

Okay latest build seems to be a better @AJenbo, if I CMD Click on methods now I actually navigate there which is good.

I do see these errors now though for Laravel Eloquent/Query Builder methods:

1:
Method 'whereIn' not found on class 'App\Models\User'phpantom(unknown_member)
Method 'query' not found on class 'App\Models\User'phpantom(unknown_member)

Even though I can click these query() etc methods and it navigates to Laravels Model class which is good.

2: Also this from spaties permission package:

While on the User model $this->hasRole() is recognized.

Questions

1. Is there a way to turn off the forwarding of phpcs messages? I'm using Laravel Pint instead. I see https://phpactor.readthedocs.io/en/master/integrations/php-cs-fixer.html this exists but no idea how/where to configure these rules with the LSP. A .phpactor.json in the root of my project seem not to make a difference.

This .phpantom.toml in projects root seems not to do anything either.

# $schema: https://github.com/AJenbo/phpantom_lsp/raw/main/config-schema.json

[formatting]

php-cs-fixer = ""

2. How does this project work with https://github.com/barryvdh/laravel-ide-helper if at all. Like, is it still useful to have that package with PHPantom?

[CicerBro]

Ha, got my names crossed up up there. Too many tabs open :-)

Any way to disable PHPCS running through PHPantom? It's installed only because it's a dependency of another package (phpcompatibility/php-compatibility)

[AJenbo]

Add a .phpantom.toml file to your project root with:

[phpcs]
command = ""

[CicerBro]

Cheers, that quiets things down a lot.

Is there anything I can do to make (for example) this get recognised?

The whereIn etc not being recognised earlier seems fixed now, I probably just had to restart Cursor. Though whereId still has that same error message. Though that's Laravel Magic, I guess because the LSP has no idea of the columns on the model unless they have PHPDoc properties etc.

[AJenbo]

Laravels auth()->user() / Auth::user() are very poorly hinted and it's a bit of an architectural problem inside of Laravel. Prople have been trying to improve it laravel/laravel#6582, we have also had some talks about workarounds we could provide: #53

But really you make a wrapper that narrows it to what you expect it to return.

function authUser(): User
{
    $user = Auth::user();
    assert($user instanceof User);
    return $user;
}

That's pretty much the conclusion from the Laravel devs as well.

[CicerBro]

Gotcha. I do like the idea of putting an alias in the toml file (at least for now).

Thanks for all the help so far. I've got it to a state where I can work with it now I think 👍🏻