diagnostics don't update

[Disservin]

PHPantom version

phpantom_lsp 0.8.0-2-g7c86d78c

Installation method

Built from source

Operating system

macOS aarch64 (Apple Silicon)

Editor

VS Code

Bug description

When for example updating the type of a function parameter previous diagnostics don't get updated and still emit the warning.

Steps to reproduce

test.php

<?php

require_once "test2.php";

function foo(string $y) {
    bar($y);
}

test2.php

<?php

function bar(null $x) {
    return $x;
}

Expected diagnostic when starting the lsp here

Argument 1 ($x) expects null, got string

after fixing bar to be bar(string $x) the diagnostic is still present and only disappears on file close/reopen or editor reload

Error output or panic trace

.phpantom.toml

default

Additional context

No response

[DarkGhostHunter]

Can confirm. Happens too in Zed. It even spawn multiple instances when trying to restart it:

[DarkGhostHunter]

I manually built (inside a distrobox) PHPantom latest commit (a4fe3e4) and everything works well, at least for the time being.

[AJenbo]

Could you please test with fd3121b

[Disservin]

nope.. didn't help

[AJenbo]

Can you provide a repo where I can replicate the issue

[Disservin]

i mean i already had a reproduction in the issue description but sure.. https://github.com/Disservin/phpantom-bug

edit the function bar(null $x) to function bar(string $x) and the error in test.php doesn't update, until you make changes in that file.. but it should auto update

[calebdw]

I've noticed this as well---the diagnostics become stale (don't update on save) and it's only until I enter/leave insert mode in neovim that it refreshes