fix(diagnostics): update after function signature change and on save#196
Open
calebdw wants to merge 1 commit into
Open
fix(diagnostics): update after function signature change and on save#196calebdw wants to merge 1 commit into
calebdw wants to merge 1 commit into
Conversation
Root cause: update_ast only tracked class signature changes. When a standalone function's parameter type changed (e.g. bar(null $x) to bar(string $x)), update_ast returned false, so schedule_diagnostics_for_open_files was never called and other open files kept showing stale diagnostics. Changes: - Add FunctionInfo::signature_eq() for comparing function signatures - Track function signature changes in update_ast: snapshot old functions before re-parse, compare signatures, clean up stale entries, and return true when any function signature changed - Add did_save handler as a reliable diagnostic refresh point (critical for Neovim which relies on save events) - Register save notification capability in TextDocumentSyncOptions - Add 23 tests covering signature_eq and update_ast change detection Closes PHPantom-dev#123
calebdw
force-pushed
the
calebdw/push-uqvsqztpwypy
branch
from
42f2bf0 to
4b6003e
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: update_ast only tracked class signature changes. When a standalone function's parameter type changed (e.g. bar(null $x) to bar(string $x)), update_ast returned false, so
schedule_diagnostics_for_open_files was never called and other open files kept showing stale diagnostics.
Changes:
Closes #123
cc: @Disservin, @DarkGhostHunter if you want to test this out