Skip to content

Commit 06a306c

Browse files
laanwjDuddino
authored andcommitted
Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) (bitcoin#10694)
1 parent 1253678 commit 06a306c

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

src/pivx-tx.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,6 @@ static void MutateTxSign(CMutableTransaction& tx, const std::string& flagStr)
453453
// mergedTx will end up with all the signatures; it
454454
// starts as a clone of the raw tx:
455455
CMutableTransaction mergedTx(txVariants[0]);
456-
bool fComplete = true;
457456
CCoinsView viewDummy;
458457
CCoinsViewCache view(&viewDummy);
459458

@@ -541,7 +540,6 @@ static void MutateTxSign(CMutableTransaction& tx, const std::string& flagStr)
541540
CTxIn& txin = mergedTx.vin[i];
542541
const Coin& coin = view.AccessCoin(txin.prevout);
543542
if (coin.IsSpent()) {
544-
fComplete = false;
545543
continue;
546544
}
547545

@@ -565,14 +563,6 @@ static void MutateTxSign(CMutableTransaction& tx, const std::string& flagStr)
565563
sigdata = CombineSignatures(prevPubKey, MutableTransactionSignatureChecker(&mergedTx, i, amount), sigdata, DataFromTransaction(txv, i));
566564
}
567565
UpdateTransaction(mergedTx, i, sigdata);
568-
if (!VerifyScript(txin.scriptSig, prevPubKey, STANDARD_SCRIPT_VERIFY_FLAGS,
569-
MutableTransactionSignatureChecker(&mergedTx, i, amount), sigversion))
570-
fComplete = false;
571-
}
572-
573-
if (fComplete) {
574-
// do nothing... for now
575-
// perhaps store this for later optional JSON output
576566
}
577567

578568
tx = mergedTx;

0 commit comments

Comments
 (0)