wip

Author: fabiencasenave

src/plaid/cli/plaidcheck.py

@@ -331,8 +331,14 @@ def _check_problem_definition_sample_features(
     """Instantiate and validate one problem-definition sample view.
 
     The sample is instantiated with the exact feature subset requested by the
-    problem definition, then each requested feature is read back and checked for
-    invalid content (None, NaN, Inf, empty arrays, object arrays containing None).
+    problem definition, then each requested feature is read back to validate
+    that the requested feature paths can actually be resolved.
+
+    Numeric content (NaN, Inf, None, empty arrays, ...) is intentionally not
+    re-checked here: the per-split loop in :func:`check_dataset` already walks
+    every sample's globals and fields and reports such issues with the
+    ``INVALID_DATA_VALUE A`` code. Re-checking them in this loop would only
+    produce duplicate warnings under a different code/location.
 
     Args:
         pb_name: Problem-definition name.
@@ -358,24 +364,14 @@ def _check_problem_definition_sample_features(
 
     for feature in features:
         try:
-            value = sample.get_feature_by_path(feature)
+            sample.get_feature_by_path(feature)
         except Exception as exc:
             report.add(
                 "error",
                 "PB_DEF_FEATURE_READ_ERROR",
                 f"{location} {feature}",
                 str(exc),
             )
-            continue
-
-        issue = _check_numeric_content(value)
-        if issue is not None:
-            report.add(
-                "warning",
-                "PB_DEF_INVALID_FEATURE_VALUE",
-                f"{location} {feature}",
-                issue,
-            )
 
 
 def compute_checksum(sample: Any) -> str:

tests/cli/test_plaidcheck.py

@@ -480,12 +480,10 @@ def test_check_problem_definition_sample_reports_feature_read_error_and_continue
         and msg.message == "cannot read Unreadable"
         for msg in report.messages
     )
-    assert any(
-        msg.severity == "warning"
-        and msg.code == "PB_DEF_INVALID_FEATURE_VALUE"
-        and msg.location == "problem_definitions/pb/test_split/test[0] BadValue"
-        and msg.message == "contains NaN"
-        for msg in report.messages
+    # Numeric content is intentionally not re-checked here: it is already
+    # validated by the per-split loop in `check_dataset`.
+    assert not any(
+        msg.code == "PB_DEF_INVALID_FEATURE_VALUE" for msg in report.messages
     )
 
 
@@ -847,14 +845,10 @@ class _PBDef:
 
     assert train_converter.feature_requests[-1] == ["Input", "Output"]
     assert test_converter.feature_requests[-1] == ["Input"]
-    invalid = [
-        msg for msg in report.messages if msg.code == "PB_DEF_INVALID_FEATURE_VALUE"
-    ]
-    assert any(
-        "train_split" in msg.location and "Output" in msg.location for msg in invalid
-    )
+    # The pb-def loop no longer re-checks numeric content; it only verifies that
+    # the requested feature subset can be converted and read back.
     assert not any(
-        "test_split" in msg.location and "Output" in msg.location for msg in invalid
+        msg.code == "PB_DEF_INVALID_FEATURE_VALUE" for msg in report.messages
     )