a11y: openlibhums#4839 full-text-search move id from view to class

Author: StephDriver

src/journal/forms.py

@@ -98,6 +98,8 @@ def __init__(self, data=None, *args, **kwargs):
                 self.data[search_filter] = "on"
         self.label_suffix = ""
 
+        self.id = "search_form"
+
     article_search = forms.CharField(
         label=_("Search term"), min_length=3, max_length=100, required=False
     )

src/journal/views.py

@@ -2242,8 +2242,6 @@ def full_text_search(request):
         request,
     )
 
-    form.id = "search_form"
-
     if search_term:
         form.is_valid()
         articles = submission_models.Article.objects.search(
@@ -2271,12 +2269,9 @@ def full_text_search(request):
         "page_obj": page_obj,
         "is_paginated": page_obj.has_other_pages(),
         "paginate_by": paginate_by,
-        "article_search": search_term,
+        "search_term": search_term,
         "keyword": keyword,
         "form": form,
-        "facet_form": form,
-        "order_by_choices": form.fields["sort"].choices,
-        "order_by": sort,
     }
 
     return render(request, template, context)