Commit 88f24f8
* fix: opt generated projects into @types globals per target (TS 6)
setup-project.sh copied a single shared tsconfig with no "types" field
into every generated project. TypeScript 6 removed the automatic
inclusion of node_modules/@types/*, so freshly generated projects
failed pnpm typecheck with TS2591/TS2584/TS2304 (process, console,
setTimeout) on all five targets.
- Split templates/shared/tsconfig.json into tsconfig.base.json plus
per-target tsconfig.node.json (types: ["node"], also used by lambda,
railway, and fly) and tsconfig.cloudflare.json (adds
@cloudflare/workers-types). Generated projects get the per-target
file as tsconfig.json plus the copied base. The snippet tsconfigs
now extend the same per-target files, so the typecheck-templates CI
job checks exactly the configuration generated projects receive.
- Install @cloudflare/workers-types for the cloudflare target; the
"types" entry references it and pnpm does not expose transitive
packages for type resolution.
- Pin typescript to its major (^6) in the generated dev dependencies
so a future TS major cannot silently break generation again.
- Copy tsconfig.base.json in the Docker build stage (node-server and
docker templates) so pnpm build keeps working in-image.
- Add a generated-projects CI matrix job that runs setup-project.sh
for every target and type-checks the result against freshly
resolved dependencies - the gap that let this regression ship.
Fixes #119
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix: make setup-project.sh executable
The script was committed mode 100644, so the documented
./scripts/setup-project.sh invocation (and the new generated-projects
CI job) fails with "Permission denied" on Linux and macOS. Never
noticed locally because Git Bash on Windows ignores the exec bit.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent ab3b3c5 commit 88f24f8
10 files changed
Lines changed: 69 additions & 13 deletions
File tree
- .github/workflows
- scripts
- templates
- docker
- node-server
- snippets
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
233 | 262 | | |
234 | 263 | | |
235 | 264 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
File renamed without changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
0 commit comments