Skip to content

ci(gui): stop pnpm side-effects cache poisoning of Electron installs #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PAMulligan merged 1 commit into from
Jul 7, 2026
Merged

ci(gui): stop pnpm side-effects cache poisoning of Electron installs #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/gui-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@ jobs:
cache: pnpm

- name: Install dependencies
run: pnpm install --frozen-lockfile
# side-effects-cache=false: the Linux runner shares the lockfile-keyed
# pnpm store cache with gui.yml, whose lint/typecheck job installs with
# ELECTRON_SKIP_BINARY_DOWNLOAD=1. Replaying that recorded postinstall
# would yield an Electron install with no binary, breaking the smoke
# test and packaging. Force postinstalls to really run.
run: pnpm install --frozen-lockfile --config.side-effects-cache=false

- name: Install Electron runtime libraries + Xvfb (Linux)
if: runner.os == 'Linux'
Expand Down
14 changes: 12 additions & 2 deletions .github/workflows/gui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,14 @@ jobs:
- name: Install dependencies
# Skip the ~100 MB Electron binary download — typecheck needs only the
# bundled types and the core tests never launch Electron.
# side-effects-cache=false: pnpm would otherwise record this *skipped*
# Electron postinstall in the pnpm store (which setup-node caches, keyed
# on the lockfile — shared with the smoke job), and any later install
# restoring that cache would replay it and never get a binary
# ("Electron failed to install correctly").
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: '1'
run: pnpm install --frozen-lockfile
run: pnpm install --frozen-lockfile --config.side-effects-cache=false

- name: Lint
run: pnpm --filter @vespasian/gui lint
Expand Down Expand Up @@ -68,7 +73,12 @@ jobs:

- name: Install dependencies
# No ELECTRON_SKIP here — the smoke needs the real Electron binary.
run: pnpm install --frozen-lockfile
# side-effects-cache=false: don't replay postinstall results from the
# restored store cache — an install that ran with
# ELECTRON_SKIP_BINARY_DOWNLOAD=1 records a binary-less Electron build,
# and replaying it here is what breaks electron.launch. This forces
# Electron's postinstall to really run (and really download).
run: pnpm install --frozen-lockfile --config.side-effects-cache=false

- name: Install Electron runtime libraries + Xvfb
run: |
Expand Down
Loading