refactor: cleanup

paul-fresquet · paul-fresquet · commit 1395a77ee9b2 · 2025-08-16T19:08:30.000+02:00
diff --git a/src/ByteSync.Client/Services/Communications/PushReceivers/SynchronizationProgressPushReceiver.cs b/src/ByteSync.Client/Services/Communications/PushReceivers/SynchronizationProgressPushReceiver.cs
@@ -61,9 +61,9 @@ private async void SynchronizationProgressChanged(SynchronizationProgressPush sy
                 await synchronizationData.SynchronizationDataTransmitted.WaitUntilTrue(SynchronizationDataTransmissionTimeout, 
                     synchronizationData.CancellationTokenSource.Token);
             }
-            catch (TimeoutException)
+            catch (TimeoutException te)
             {
-                _logger.LogError("Timeout waiting for synchronization data transmission ({Timeout}) for session {SessionId}", 
+                _logger.LogError(te, "Timeout waiting for synchronization data transmission ({Timeout}) for session {SessionId}", 
                     SynchronizationDataTransmissionTimeout, sessionId);
                 return;
             }
diff --git a/src/ByteSync.Client/Services/Sessions/Connecting/AfterJoinSessionService.cs b/src/ByteSync.Client/Services/Sessions/Connecting/AfterJoinSessionService.cs
@@ -263,7 +263,7 @@ private void DebugAddDesktopDataSource(string folderName)
             FileSystemTypes.Directory, dataNode);
     }
 
-    private string GeneratePassword()
+    private static string GeneratePassword()
     {
         var sb = new StringBuilder();
         for (var i = 0; i < 5; i++)

Original file line number	Diff line number	Diff line change
`@@ -61,9 +61,9 @@ private async void SynchronizationProgressChanged(SynchronizationProgressPush sy`
`61`	`61`	`await synchronizationData.SynchronizationDataTransmitted.WaitUntilTrue(SynchronizationDataTransmissionTimeout,`
`62`	`62`	`synchronizationData.CancellationTokenSource.Token);`
`63`	`63`	`}`
`64`		`- catch (TimeoutException)`
	`64`	`+ catch (TimeoutException te)`
`65`	`65`	`{`
`66`		`- _logger.LogError("Timeout waiting for synchronization data transmission ({Timeout}) for session {SessionId}",`
	`66`	`+ _logger.LogError(te, "Timeout waiting for synchronization data transmission ({Timeout}) for session {SessionId}",`
`67`	`67`	`SynchronizationDataTransmissionTimeout, sessionId);`
`68`	`68`	`return;`
`69`	`69`	`}`
Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,7 @@ private void DebugAddDesktopDataSource(string folderName)`
`263`	`263`	`FileSystemTypes.Directory, dataNode);`
`264`	`264`	`}`
`265`	`265`
`266`		`- private string GeneratePassword()`
	`266`	`+ private static string GeneratePassword()`
`267`	`267`	`{`
`268`	`268`	`var sb = new StringBuilder();`
`269`	`269`	`for (var i = 0; i < 5; i++)`