feat: remove useless acquireLock

feat: improve SessionMemberData.AuthCheckClientInstanceIds management

Author: paul-fresquet

src/ByteSync.ServerCommon/Commands/CloudSessions/FinalizeJoinCloudSessionCommandHandler.cs

@@ -43,8 +43,6 @@ public async Task<FinalizeJoinSessionResult> Handle(FinalizeJoinCloudSessionRequ
 
         var transaction = _redisInfrastructureService.OpenTransaction();
 
-        await using var sessionRedisLock = await _redisInfrastructureService.AcquireLockAsync(EntityType.Session, parameters.SessionId);
-
         var updateResult = await _cloudSessionsRepository.Update(parameters.SessionId, innerCloudSessionData =>
         {
             if (innerCloudSessionData.IsSessionRemoved)
@@ -99,7 +97,7 @@ public async Task<FinalizeJoinSessionResult> Handle(FinalizeJoinCloudSessionRequ
             {
                 return false;
             }
-        }, transaction, sessionRedisLock);
+        }, transaction);
 
         if (updateResult.IsWaitingForTransaction)
         {

src/ByteSync.ServerCommon/Commands/Trusts/SendDigitalSignaturesCommandHandler.cs

@@ -71,7 +71,11 @@ await _cloudSessionsRepository.Update(cloudSession.SessionId, cloudSessionData =
                     {
                         foreach (var digitalSignatureCheckInfo in parameters.DigitalSignatureCheckInfos)
                         {
-                            member.AuthCheckClientInstanceIds.Add(digitalSignatureCheckInfo.Recipient);
+                            var recipient = digitalSignatureCheckInfo.Recipient;
+                            if (!member.AuthCheckClientInstanceIds.Contains(recipient))
+                            {
+                                member.AuthCheckClientInstanceIds.Add(recipient);
+                            }
                         }
 
                         return true;