refactor: centralize noise file detection

Author: paul-fresquet

src/ByteSync.Client/Services/Inventories/FileSystemInspector.cs

@@ -63,13 +63,7 @@ public bool IsSystemAttribute(FileInfo fileInfo)
 
     public bool IsNoiseFileName(FileInfo fileInfo, OSPlatforms os)
     {
-        var comparison = os == OSPlatforms.Linux ? StringComparison.Ordinal : StringComparison.OrdinalIgnoreCase;
-        
-        return fileInfo.Name.Equals("desktop.ini", comparison)
-               || fileInfo.Name.Equals("thumbs.db", comparison)
-               || fileInfo.Name.Equals(".desktop.ini", comparison)
-               || fileInfo.Name.Equals(".thumbs.db", comparison)
-               || fileInfo.Name.Equals(".DS_Store", comparison);
+        return NoiseFileDetector.IsNoiseFileName(fileInfo.Name, os);
     }
 
     public bool IsReparsePoint(FileSystemInfo fsi)
@@ -120,4 +114,4 @@ private bool SafeIsReparsePoint(FileSystemInfo fsi)
             return false;
         }
     }
-}
+}

src/ByteSync.Client/Services/Inventories/NoiseFileDetector.cs

@@ -0,0 +1,40 @@
+using ByteSync.Common.Business.Misc;
+
+namespace ByteSync.Services.Inventories;
+
+public static class NoiseFileDetector
+{
+    private static readonly string[] KnownNoiseFileNames =
+    [
+        "desktop.ini",
+        "thumbs.db",
+        "ehthumbs.db",
+        "ehthumbs_vista.db",
+        ".desktop.ini",
+        ".thumbs.db",
+        ".DS_Store",
+        ".AppleDouble",
+        ".LSOverride",
+        ".Spotlight-V100",
+        ".Trashes",
+        ".fseventsd",
+        ".TemporaryItems",
+        ".VolumeIcon.icns",
+        ".directory"
+    ];
+
+    private static readonly HashSet<string> CaseSensitiveNoiseFileNames = new(KnownNoiseFileNames, StringComparer.Ordinal);
+    private static readonly HashSet<string> CaseInsensitiveNoiseFileNames = new(KnownNoiseFileNames, StringComparer.OrdinalIgnoreCase);
+
+    public static bool IsNoiseFileName(string? fileName, OSPlatforms os)
+    {
+        if (string.IsNullOrWhiteSpace(fileName))
+        {
+            return false;
+        }
+
+        return os == OSPlatforms.Linux
+            ? CaseSensitiveNoiseFileNames.Contains(fileName)
+            : CaseInsensitiveNoiseFileNames.Contains(fileName);
+    }
+}