fix: fix concurrency on collection

Author: paul-fresquet

src/ByteSync.ServerCommon/Interfaces/Services/ISynchronizationProgressService.cs

@@ -16,7 +16,7 @@ public interface ISynchronizationProgressService
 
     Task<Synchronization> MapToSynchronization(SynchronizationEntity synchronizationEntity);
 
-    Task UploadIsFinished(SharedFileDefinition sharedFileDefinition, int totalParts, HashSet<string> targetInstanceIds);
+    Task UploadIsFinished(SharedFileDefinition sharedFileDefinition, int totalParts, ICollection<string> targetInstanceIds);
 
     Task FilePartIsUploaded(SharedFileDefinition sharedFileDefinition, int partNumber, HashSet<string> targetInstanceIds);
 }

src/ByteSync.ServerCommon/Services/SynchronizationProgressService.cs

@@ -51,7 +51,7 @@ public async Task InformSynchronizationStarted(SynchronizationEntity synchroniza
         await _invokeClientsService.SessionGroup(synchronization.SessionId).SynchronizationStarted(synchronization);
     }
 
-    public async Task UploadIsFinished(SharedFileDefinition sharedFileDefinition, int totalParts, HashSet<string> targetInstanceIds)
+    public async Task UploadIsFinished(SharedFileDefinition sharedFileDefinition, int totalParts, ICollection<string> targetInstanceIds)
     {
         await _sharedFilesService.AssertUploadIsFinished(sharedFileDefinition, totalParts, targetInstanceIds);
 

src/ByteSync.ServerCommon/Services/SynchronizationService.cs

@@ -1,4 +1,5 @@
-using ByteSync.Common.Business.Actions;
+using System.Collections.Concurrent;
+using ByteSync.Common.Business.Actions;
 using ByteSync.Common.Business.SharedFiles;
 using ByteSync.Common.Business.Synchronizations;
 using ByteSync.Common.Helpers;
@@ -77,7 +78,7 @@ public async Task OnUploadIsFinishedAsync(SharedFileDefinition sharedFileDefinit
     {
         var actionsGroupsIds = sharedFileDefinition.ActionsGroupIds;
 
-        HashSet<string> targetInstanceIds = new HashSet<string>();
+        ConcurrentBag<string> targetInstanceIds = new ConcurrentBag<string>();
 
         var result = await _trackingActionRepository.AddOrUpdate(sharedFileDefinition.SessionId, actionsGroupsIds!, (trackingAction, synchronization) =>
         {
@@ -87,15 +88,18 @@ public async Task OnUploadIsFinishedAsync(SharedFileDefinition sharedFileDefinit
             }
 
             trackingAction.IsSourceSuccess = true;
-                
-            targetInstanceIds.AddAll(trackingAction.TargetClientInstanceIds);
+
+            foreach (var targetClientInstanceId in trackingAction.TargetClientInstanceIds)
+            {
+                targetInstanceIds.Add(targetClientInstanceId);
+            }
 
             return new TrackingActionUpdateHandlerResult(true);
         });
 
         if (result.IsSuccess)
         {
-            await _synchronizationProgressService.UploadIsFinished(sharedFileDefinition, totalParts, targetInstanceIds);
+            await _synchronizationProgressService.UploadIsFinished(sharedFileDefinition, totalParts, targetInstanceIds.ToList());
         }
     }
 

tests/ByteSync.ServerCommon.Tests/Services/SynchronizationServiceTests.cs

@@ -176,7 +176,7 @@ public async Task OnUploadIsFinishedAsync_WhenCheckSynchronizationSuccess_RunsNo
         A.CallTo(() => _synchronizationStatusCheckerService.CheckSynchronizationCanBeUpdated(synchronizationEntity))
             .Returns(true);
 
-        A.CallTo(() => _synchronizationProgressService.UploadIsFinished(sharedFileDefinition, 1, A<HashSet<string>>.That.Contains("targetClientInstanceId")))
+        A.CallTo(() => _synchronizationProgressService.UploadIsFinished(sharedFileDefinition, 1, A<ICollection<string>>.That.Contains("targetClientInstanceId")))
             .Returns(Task.CompletedTask);
 
         // Act
@@ -187,7 +187,7 @@ public async Task OnUploadIsFinishedAsync_WhenCheckSynchronizationSuccess_RunsNo
             .MustHaveHappenedOnceExactly();
         A.CallTo(() => _synchronizationStatusCheckerService.CheckSynchronizationCanBeUpdated(synchronizationEntity))
             .MustHaveHappenedOnceExactly();
-        A.CallTo(() => _synchronizationProgressService.UploadIsFinished(sharedFileDefinition, 1, A<HashSet<string>>.That.Contains("targetClientInstanceId")))
+        A.CallTo(() => _synchronizationProgressService.UploadIsFinished(sharedFileDefinition, 1, A<ICollection<string>>.That.Contains("targetClientInstanceId")))
             .MustHaveHappenedOnceExactly();
     }