Skip to content

Commit dba74d5

Browse files
committed
refactor: cleanup
1 parent 39a9ea6 commit dba74d5

1 file changed

Lines changed: 2 additions & 53 deletions

File tree

src/ByteSync.Client/Services/Actions/SharedActionsGroupComputer.cs

Lines changed: 2 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -30,47 +30,10 @@ public SharedActionsGroupComputer(ISharedAtomicActionRepository sharedAtomicActi
3030
public async Task ComputeSharedActionsGroups()
3131
{
3232
var sharedAtomicActions = _sharedAtomicActionRepository.Elements;
33-
34-
// var tasks = new List<Task>();
33+
3534
var dictionary = sharedAtomicActions.GroupBy(saa => saa.PathIdentity)
3635
.ToDictionary(g => g.Key, g => g.ToList());
3736

38-
// foreach (KeyValuePair<PathIdentity, List<SharedAtomicAction>> pair in dictionary)
39-
// {
40-
// tasks.Add(Task.Run(() => ComputeGroups_CopyContentAndDate(pair.Value)));
41-
// tasks.Add(Task.Run(() => ComputeGroups_CopyContent(pair.Value)));
42-
// tasks.Add(Task.Run(() => ComputeGroups_CopyDate(pair.Value)));
43-
// tasks.Add(Task.Run(() => ComputeGroups_Create(pair.Value)));
44-
// tasks.Add(Task.Run(() => ComputeGroups_Delete(pair.Value)));
45-
// }
46-
//
47-
// await Task.WhenAll(tasks);
48-
49-
// await Task.Run(() => {
50-
// Parallel.ForEach(
51-
// dictionary,
52-
// new ParallelOptions { MaxDegreeOfParallelism = Environment.ProcessorCount * 2 },
53-
// pair => {
54-
// ComputeGroups_CopyContentAndDate(pair.Value).Wait();
55-
// ComputeGroups_CopyContent(pair.Value).Wait();
56-
// ComputeGroups_CopyDate(pair.Value).Wait();
57-
// ComputeGroups_Create(pair.Value).Wait();
58-
// ComputeGroups_Delete(pair.Value).Wait();
59-
// }
60-
// );
61-
// });
62-
63-
// await Parallel.ForEachAsync(dictionary, new ParallelOptions { MaxDegreeOfParallelism = Environment.ProcessorCount * 2 }, async (pair, ct) =>
64-
// {
65-
// await Task.WhenAll(
66-
// Task.Run(() => ComputeGroups_CopyContentAndDate(pair.Value)),
67-
// Task.Run(() => ComputeGroups_CopyContent(pair.Value)),
68-
// Task.Run(() => ComputeGroups_CopyDate(pair.Value)),
69-
// Task.Run(() => ComputeGroups_Create(pair.Value)),
70-
// Task.Run(() => ComputeGroups_Delete(pair.Value))
71-
// );
72-
// });
73-
7437
await Parallel.ForEachAsync(dictionary, new ParallelOptions { MaxDegreeOfParallelism = Environment.ProcessorCount * 2 }, (pair, _) =>
7538
{
7639
ComputeGroups_CopyContentAndDate(pair.Value);
@@ -246,13 +209,6 @@ private void AffectSharedActionsGroupId(SharedActionsGroup sharedActionsGroup, L
246209

247210
private void AddSharedActionsGroups(List<SharedActionsGroup> sharedActionsGroups)
248211
{
249-
// if (sharedActionsGroups.Count > 0)
250-
// {
251-
// _sharedActionsGroupRepository.AddOrUpdate(sharedActionsGroups);
252-
// }
253-
//
254-
// AddToBuffer(sharedActionsGroups);
255-
256212
lock (_lock)
257213
{
258214
_buffer.AddAll(sharedActionsGroups);
@@ -262,11 +218,6 @@ private void AddSharedActionsGroups(List<SharedActionsGroup> sharedActionsGroups
262218

263219
}
264220

265-
// private void AddToBuffer(List<SharedActionsGroup> sharedActionsGroups)
266-
// {
267-
// _buffer.AddAll(sharedActionsGroups);
268-
// }
269-
270221
private void AddSharedActionsGroup(SharedActionsGroup sharedActionsGroup)
271222
{
272223
lock (_lock)
@@ -275,8 +226,6 @@ private void AddSharedActionsGroup(SharedActionsGroup sharedActionsGroup)
275226

276227
CheckBuffer();
277228
}
278-
279-
// _sharedActionsGroupRepository.AddOrUpdate(sharedActionsGroup);
280229
}
281230

282231
private void CheckBuffer()
@@ -291,7 +240,7 @@ private void CheckBuffer()
291240
private static List<List<SharedAtomicAction>> GetCopyGroups(IEnumerable<SharedAtomicAction> sharedAtomicActions, bool isContentAndDate)
292241
{
293242
var root = sharedAtomicActions
294-
.Where(saa => saa.Target != null) // La target peut être null dans certains cas avec les règles de synchronisation
243+
.Where(saa => saa.Target != null) // The target may be null in some cases with synchronization rules
295244
.GroupBy(saa => saa.Source!)
296245
.Select(x => new
297246
{

0 commit comments

Comments
 (0)