-
Notifications
You must be signed in to change notification settings - Fork 10
[migration] Migrate project to SDK 10 and fix deprecations #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c5cf039
e99e739
345dcc5
75f3c04
0302077
99a04eb
bb221f9
6dc43fb
b389a39
8bc8c8e
f53a5ee
5b0fc48
eb3d4b7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||||
| using System.Net; | ||||||||
| using System.Net; | ||||||||
| using Microsoft.Azure.Functions.Worker; | ||||||||
| using Microsoft.Azure.Functions.Worker.Http; | ||||||||
| using ByteSync.Common.Business.Sessions.Cloud.Connections; | ||||||||
|
|
@@ -32,7 +32,8 @@ public async Task<HttpResponseData> StartTrustCheck( | |||||||
| var result = await _mediator.Send(request); | ||||||||
|
|
||||||||
| var response = req.CreateResponse(); | ||||||||
|
||||||||
| var response = req.CreateResponse(); | |
| var response = req.CreateResponse(); | |
| response.StatusCode = HttpStatusCode.OK; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I missed this one. The fix has been pushed: response.StatusCode is now explicitly set to HttpStatusCode.OK prior to serialization, perfectly matching the other Trust endpoints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description says Microsoft.Azure.AppConfiguration.AspNetCore was upgraded to 8.5.0, but this project still references 8.1.2. Either bump this PackageReference to the intended version or adjust the PR description/table so it matches the actual upgrade set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in commit f53a5ee