api error case fixed

Author: Zayn-Javed

src/engine/universal/core/src/engine/engine.js

@@ -245,18 +245,10 @@ class Engine {
   /**
    * Returns whether the given process version is currently deployed in the NeoBPMN Engine
    *
-   * @param {string} definitionId the id of the process definition
    * @param {string} versionId the version of the process to check
    * @returns {boolean} true if the version is deployed, false if it is known but not active
-   * @throws {Error} if the version has never been deployed to this engine
    */
-  async isProcessVersionDeployed(definitionId, versionId) {
-    try {
-      await distribution.db.getProcessVersion(definitionId, versionId);
-    } catch {
-      throw new Error(`Version ${versionId} has never been deployed to this engine.`);
-    }
-
+  async isProcessVersionDeployed(versionId) {
     return this._versionProcessMapping[versionId]?.isDeployed() ?? false;
   }
 

src/engine/universal/distribution/src/routes/ProcessInstanceRoutes.js

@@ -463,30 +463,25 @@ module.exports = (path, management) => {
 
   network.get(`${path}/:definitionId/versions/:version/active`, { cors: true }, async (req) => {
     const { definitionId, version } = req.params;
-    const engine = management.getEngineWithDefinitionId(definitionId);
-
-    if (!engine) {
-      return {
-        statusCode: 200,
-        mimeType: 'application/json',
-        response: JSON.stringify({ active: false }),
-      };
-    }
 
     try {
-      return {
-        statusCode: 200,
-        mimeType: 'application/json',
-        response: JSON.stringify({
-          active: await engine.isProcessVersionDeployed(definitionId, version),
-        }),
-      };
-    } catch (_) {
+      await db.getProcessVersion(definitionId, version);
+    } catch {
       return {
         statusCode: 404,
         mimeType: 'text/plain',
         response: 'The requested version is not found in this engine.',
       };
     }
+
+    const engine = management.getEngineWithDefinitionId(definitionId);
+
+    return {
+      statusCode: 200,
+      mimeType: 'application/json',
+      response: JSON.stringify({
+        active: engine ? await engine.isProcessVersionDeployed(version) : false,
+      }),
+    };
   });
 };