Skip to content

Commit 18e6fdf

Browse files
committed
Throwing error when user task contains invalid global data access
1 parent 30efb3d commit 18e6fdf

2 files changed

Lines changed: 6 additions & 9 deletions

File tree

src/engine/universal/ui/src/display-items/tasklist/TaskList-DisplayItem.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/management-system-v2/lib/engines/server-actions.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -340,23 +340,20 @@ export async function getGlobalVariablesForHTML(
340340
} else if (segments[0] === '@worker' || !segments[0].startsWith('@')) {
341341
({ userId } = await getCurrentUser());
342342
} else if (segments[0] !== '@organization') {
343-
console.error(`Invalid selector for global data access in user task html. (${segments[0]})`);
344-
return;
343+
throw new UserFacingError(
344+
`Invalid selector for global data access in user task html. (${segments[0]})`,
345+
);
345346
}
346347

347348
if (segments[0].startsWith('@')) segments = segments.slice(1);
348349

349350
const result = await getDataObject(spaceId, segments.join('.'), userId);
350351

351352
if (isErrorResponse(result)) {
352-
console.error(
353-
'Ecountered error while trying to get global variable for user task rendering:',
354-
await result.data.text(),
355-
);
356-
return;
353+
throw new UserFacingError(await result.data.text());
357354
}
358355

359-
return result.data.value;
356+
return result.data?.value;
360357
});
361358
}
362359

0 commit comments

Comments
 (0)