-
Notifications
You must be signed in to change notification settings - Fork 10
Mcp authorization control #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jjoderis
wants to merge
10
commits into
main
Choose a base branch
from
mcp-authorization-control
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cb4a4b7
Removed test prompts and and resources
jjoderis f1bc1c2
Fixed: the "Manage Executions" control in the role permission section…
jjoderis 8b50c38
Added authorization checks for data access in mcp tools
jjoderis 3429ad4
Added a new tool that tells an llm which of the other tools can actua…
jjoderis 3117d39
Ran prettier
jjoderis 68cf13b
Merge branch 'main' of github.com:PROCEED-Labs/proceed into mcp-autho…
jjoderis c9bd2ee
Removed the MCP Encryption Key Environment Variable that was not used…
jjoderis d8c8257
Ran prettier
jjoderis 6fa65bc
Merge branch 'main' of github.com:PROCEED-Labs/proceed into mcp-autho…
jjoderis 130fe90
Merge branch 'main' of https://github.com/PROCEED-Labs/proceed into m…
canptura File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| import { type InferSchema } from 'xmcp'; | ||
| import { isAccessible, toAuthorizationSchema, verifyCode } from '@/lib/mcp-utils'; | ||
| import { isUserErrorResponse } from '@/lib/user-error'; | ||
|
|
||
| // Define the schema for tool parameters | ||
| export const schema = toAuthorizationSchema({}); | ||
|
|
||
| // Define tool metadata | ||
| export const metadata = { | ||
| name: 'get-accessible-tools', | ||
| description: | ||
| 'Get all of the available tools that the current user can access in the current space. Some of the tools that are exposed through MCP might be blocked due to the configuration of the space or the permissions of the user in the space.', | ||
| annotations: { | ||
| title: 'Get Available Tools', | ||
| readOnlyHint: true, | ||
| destructiveHint: false, | ||
| idempotentHint: true, | ||
| }, | ||
| }; | ||
|
|
||
| // Tool implementation | ||
| export default async function getAvailableTools({ userCode }: InferSchema<typeof schema>) { | ||
| try { | ||
| const verification = await verifyCode(userCode); | ||
|
|
||
| if (isUserErrorResponse(verification)) return `Error: ${verification.error.message}`; | ||
|
|
||
| const { userId, environmentId } = verification; | ||
|
|
||
| const canAccessProcesses = await isAccessible( | ||
| userId, | ||
| environmentId, | ||
| ['PROCEED_PUBLIC_PROCESS_DOCUMENTATION_ACTIVE'], | ||
| ['process-documentation'], | ||
| [['view', 'Process']], | ||
| ); | ||
|
|
||
| let canAccessTasks = await isAccessible( | ||
| userId, | ||
| environmentId, | ||
| ['PROCEED_PUBLIC_PROCESS_AUTOMATION_ACTIVE'], | ||
| ['process-automation.tasklist'], | ||
| [['view', 'Task']], | ||
| ); | ||
|
|
||
| let canAccessInstances = await isAccessible( | ||
| userId, | ||
| environmentId, | ||
| ['PROCEED_PUBLIC_PROCESS_AUTOMATION_ACTIVE'], | ||
| ['process-automation.executions'], | ||
| [['view', 'Execution']], | ||
| ); | ||
|
|
||
| let canCreateInstances = await isAccessible( | ||
| userId, | ||
| environmentId, | ||
| ['PROCEED_PUBLIC_PROCESS_AUTOMATION_ACTIVE'], | ||
| ['process-automation.executions'], | ||
| [['create', 'Execution']], | ||
| ); | ||
|
|
||
| const tools = { | ||
| 'get-processes': canAccessProcesses, | ||
| 'get-process-info': canAccessProcesses, | ||
| 'start-process': canCreateInstances, | ||
| 'get-organization-data': true, | ||
| 'get-user-data': true, | ||
| }; | ||
|
|
||
| const result = Object.entries(tools) | ||
| .filter(([_, accessible]) => accessible) | ||
| .map(([name]) => name); | ||
|
|
||
| return { | ||
| content: [{ type: 'text', text: JSON.stringify(result) }], | ||
| }; | ||
| } catch (err) { | ||
| if (err instanceof Error) return err.message; | ||
| else return 'Error: Something went wrong'; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you're only iterating over the elements of path wouldn't it be more readable with a "for of" iteration?